Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused variables #7968

Merged

Conversation

DonIsaac
Copy link
Contributor

What This PR Does

Removes all declared, but unused, variables. This is part of an effort to keep Oxlint's CI pipelines green, as we are in the process of promoting no-unused-vars to correctness. Thank you for using Oxlint ❤️

Note: I am the product manager of Oxlint

@CLAassistant
Copy link

CLAassistant commented Aug 25, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

graphite-app bot commented Aug 25, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added mod:infra Environment related issues and discussions mod:i18n Related to i18n mod:component app:electron Related to electron app app:server app:core labels Aug 25, 2024
Copy link

nx-cloud bot commented Aug 26, 2024

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 7 lines in your changes missing coverage. Please review.

Project coverage is 55.18%. Comparing base (01c9d17) to head (dd0724f).
Report is 2 commits behind head on canary.

Files Patch % Lines
packages/backend/server/src/core/auth/service.ts 0.00% 1 Missing ⚠️
packages/backend/server/src/core/quota/service.ts 0.00% 1 Missing ⚠️
packages/backend/server/src/core/utils/doc.ts 0.00% 1 Missing ⚠️
...s/backend/server/src/core/workspaces/controller.ts 0.00% 1 Missing ⚠️
...ges/backend/server/src/fundamentals/helpers/url.ts 0.00% 1 Missing ⚠️
...server/src/fundamentals/storage/providers/utils.ts 0.00% 1 Missing ⚠️
...rc/plugins/copilot/workflow/executor/check-html.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7968      +/-   ##
==========================================
- Coverage   55.22%   55.18%   -0.05%     
==========================================
  Files        1053     1053              
  Lines       44678    44678              
  Branches     5263     5262       -1     
==========================================
- Hits        24674    24656      -18     
- Misses      19626    19644      +18     
  Partials      378      378              
Flag Coverage Δ
server-test 77.60% <22.22%> (-0.08%) ⬇️
unittest 26.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Aug 26, 2024

Merge activity

  • Aug 26, 2:11 AM EDT: forehalo added this pull request to the Graphite merge queue.
  • Aug 26, 2:23 AM EDT: The Graphite merge queue couldn't merge this PR because it failed for an unknown reason (Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge).

@forehalo forehalo merged commit dbcfd24 into toeverything:canary Aug 26, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:electron Related to electron app app:server mod:component mod:i18n Related to i18n mod:infra Environment related issues and discussions
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants