Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add sign in button to shared doc #7952

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Aug 23, 2024

CleanShot 2024-08-23 at 12 05 12@2x

Copy link

graphite-app bot commented Aug 23, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

JimmFly commented Aug 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JimmFly and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added test Related to test cases app:core labels Aug 23, 2024
Copy link

nx-cloud bot commented Aug 23, 2024

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.23%. Comparing base (dde4574) to head (4ec45a2).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #7952   +/-   ##
=======================================
  Coverage   55.23%   55.23%           
=======================================
  Files        1060     1060           
  Lines       44768    44768           
  Branches     5278     5278           
=======================================
  Hits        24729    24729           
  Misses      19658    19658           
  Partials      381      381           
Flag Coverage Δ
server-test 77.65% <ø> (ø)
unittest 27.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the mod:i18n Related to i18n label Aug 23, 2024
@JimmFly JimmFly marked this pull request as ready for review August 23, 2024 04:05
@JimmFly JimmFly force-pushed the jimmfly/0823/share-sign-in branch 2 times, most recently from c85a41c to 9a4c32c Compare August 27, 2024 07:59
Copy link

graphite-app bot commented Aug 29, 2024

Merge activity

@graphite-app graphite-app bot merged commit 4ec45a2 into canary Aug 29, 2024
34 checks passed
@graphite-app graphite-app bot deleted the jimmfly/0823/share-sign-in branch August 29, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:i18n Related to i18n test Related to test cases
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants