Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): adjust share menu ui #7931

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Aug 21, 2024

CleanShot.2024-08-21.at.11.27.13.mp4

Copy link

graphite-app bot commented Aug 21, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@JimmFly JimmFly marked this pull request as ready for review August 21, 2024 03:26
Copy link
Member Author

JimmFly commented Aug 21, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JimmFly and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Aug 21, 2024

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.18%. Comparing base (b57388f) to head (920afa7).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7931      +/-   ##
==========================================
- Coverage   55.22%   55.18%   -0.04%     
==========================================
  Files        1054     1053       -1     
  Lines       44680    44675       -5     
  Branches     5263     5262       -1     
==========================================
- Hits        24673    24653      -20     
- Misses      19629    19644      +15     
  Partials      378      378              
Flag Coverage Δ
server-test 77.60% <ø> (-0.08%) ⬇️
unittest 26.96% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Aug 23, 2024

Merge activity

@EYHN EYHN force-pushed the jimmfly/0821/adjust-share branch from 3118de6 to 920afa7 Compare August 23, 2024 02:07
@graphite-app graphite-app bot merged commit 920afa7 into canary Aug 23, 2024
33 checks passed
@graphite-app graphite-app bot deleted the jimmfly/0821/adjust-share branch August 23, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants