Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin): nav bar incorrectly active state #7870

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Aug 14, 2024

No description provided.

Copy link

graphite-app bot commented Aug 14, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@JimmFly JimmFly marked this pull request as ready for review August 14, 2024 06:50
Copy link
Member Author

JimmFly commented Aug 14, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JimmFly and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Aug 14, 2024

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.39%. Comparing base (d5ecf50) to head (5c67f98).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7870      +/-   ##
==========================================
- Coverage   52.44%   52.39%   -0.05%     
==========================================
  Files        1230     1230              
  Lines       48340    48340              
  Branches     5905     5904       -1     
==========================================
- Hits        25351    25327      -24     
- Misses      22614    22638      +24     
  Partials      375      375              
Flag Coverage Δ
server-test 77.28% <ø> (-0.08%) ⬇️
unittest 25.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@forehalo forehalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JimmFly JimmFly force-pushed the jimmfly/0814/fix-nav branch 2 times, most recently from d0693b9 to bb0bc2d Compare August 15, 2024 07:41
@JimmFly JimmFly requested a review from forehalo August 16, 2024 10:39
Copy link

graphite-app bot commented Sep 5, 2024

Merge activity

@graphite-app graphite-app bot merged commit 5c67f98 into canary Sep 5, 2024
38 checks passed
@graphite-app graphite-app bot deleted the jimmfly/0814/fix-nav branch September 5, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants