Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(core): avoid page init when only id required #7867

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

forehalo
Copy link
Member

No description provided.

Copy link

graphite-app bot commented Aug 14, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @forehalo and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Aug 14, 2024

@forehalo forehalo force-pushed the 61/journal-perf branch 2 times, most recently from b9d77d0 to 6edbe40 Compare August 14, 2024 04:45
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 55.62%. Comparing base (05ac3db) to head (99e70c9).

Files Patch % Lines
packages/frontend/core/src/hooks/use-journal.ts 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7867      +/-   ##
==========================================
- Coverage   55.63%   55.62%   -0.01%     
==========================================
  Files        1020     1020              
  Lines       43740    43739       -1     
  Branches     5200     5200              
==========================================
- Hits        24333    24332       -1     
  Misses      19036    19036              
  Partials      371      371              
Flag Coverage Δ
server-test 78.77% <ø> (ø)
unittest 26.98% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Aug 14, 2024

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants