Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electron): cmd+num not working on mac #7865

Merged

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Aug 14, 2024

fix AF-1248
hidden menu group + acceleratorWorksWhenHidden does not work on mac

Copy link

graphite-app bot commented Aug 14, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@pengx17 pengx17 marked this pull request as ready for review August 14, 2024 03:33
Copy link
Collaborator Author

pengx17 commented Aug 14, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the app:electron Related to electron app label Aug 14, 2024
Copy link

nx-cloud bot commented Aug 14, 2024

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.58%. Comparing base (08cc15a) to head (41b2da8).
Report is 5 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7865      +/-   ##
==========================================
+ Coverage   55.55%   55.58%   +0.03%     
==========================================
  Files        1020     1020              
  Lines       43722    43740      +18     
  Branches     5199     5199              
==========================================
+ Hits        24288    24314      +26     
+ Misses      19063    19055       -8     
  Partials      371      371              
Flag Coverage Δ
server-test 78.70% <ø> (+0.04%) ⬆️
unittest 26.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the xp/08-14-fix_electron_cmd_num_not_working_on_mac branch from 07579bc to 41b2da8 Compare August 14, 2024 03:59
@github-actions github-actions bot added the test Related to test cases label Aug 14, 2024
Copy link

graphite-app bot commented Aug 14, 2024

Merge activity

fix AF-1248
hidden menu group + acceleratorWorksWhenHidden does not work on mac
@pengx17 pengx17 force-pushed the xp/08-14-fix_electron_cmd_num_not_working_on_mac branch from 41b2da8 to d5edada Compare August 14, 2024 04:14
@graphite-app graphite-app bot merged commit d5edada into canary Aug 14, 2024
33 checks passed
@graphite-app graphite-app bot deleted the xp/08-14-fix_electron_cmd_num_not_working_on_mac branch August 14, 2024 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:electron Related to electron app test Related to test cases
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants