fix(admin): user form not dynamically updating as expected #7858
+24
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 994b539. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
JimmFly
changed the title
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #7858 +/- ##
==========================================
+ Coverage 55.58% 55.62% +0.04%
==========================================
Files 1020 1020
Lines 43740 43740
Branches 5199 5200 +1
==========================================
+ Hits 24314 24332 +18
+ Misses 19055 19037 -18
Partials 371 371
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
forehalo
reviewed
Aug 14, 2024
forehalo
changed the base branch from
jimmfly/0813/fix-search-auth
to
graphite-base/7858
forehalo
force-pushed
the
jimmfly/0813/fix-user-form
branch
from
9a2f98f
to
e8ee011
Compare
forehalo
force-pushed
the
graphite-base/7858
branch
from
4e4431c
to
05247bb
Compare
forehalo
approved these changes
Aug 14, 2024
Merge activity
|
- Fixed the issue that a certain feature must be enabled when creating a user - Fixed the issue that the modified content was not reset to the default content when exiting the user form without saving after modification - Fixed the issue that the content did not switch as expected when switching user forms of different users https://github.com/user-attachments/assets/02567021-9342-4ed1-be77-3bdcbb3d86ab
forehalo
force-pushed
the
jimmfly/0813/fix-user-form
branch
from
e8ee011
to
994b539
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CleanShot.2024-08-14.at.01.10.15.mp4