Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: center peek support open in new tab #7848

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Aug 13, 2024

No description provided.

Copy link

graphite-app bot commented Aug 13, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

pengx17 commented Aug 13, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@pengx17 pengx17 marked this pull request as ready for review August 13, 2024 07:08
Copy link

nx-cloud bot commented Aug 13, 2024

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.54%. Comparing base (171a974) to head (d86f7f4).

Files Patch % Lines
.../src/modules/peek-view/view/peek-view-controls.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #7848   +/-   ##
=======================================
  Coverage   55.54%   55.54%           
=======================================
  Files        1020     1020           
  Lines       43722    43720    -2     
  Branches     5201     5199    -2     
=======================================
  Hits        24284    24284           
+ Misses      19068    19066    -2     
  Partials      370      370           
Flag Coverage Δ
server-test 78.64% <ø> (ø)
unittest 26.98% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Aug 13, 2024

Merge activity

@pengx17 pengx17 force-pushed the 08-13-fix_center_peek_support_open_in_new_tab branch from 3916654 to d86f7f4 Compare August 13, 2024 07:52
@graphite-app graphite-app bot merged commit d86f7f4 into canary Aug 13, 2024
33 checks passed
@graphite-app graphite-app bot deleted the 08-13-fix_center_peek_support_open_in_new_tab branch August 13, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants