Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): highlight doc title in search result #7786

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Aug 8, 2024

No description provided.

Copy link

graphite-app bot commented Aug 8, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@EYHN EYHN marked this pull request as ready for review August 8, 2024 08:16
Copy link
Member Author

EYHN commented Aug 8, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EYHN and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Aug 8, 2024

@EYHN EYHN changed the base branch from eyhn/fix/search-result to graphite-base/7786 August 8, 2024 08:18
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 26.77%. Comparing base (03fd23d) to head (c7aabd3).

Files Patch % Lines
...rontend/core/src/modules/quicksearch/impls/docs.ts 0.00% 2 Missing ⚠️
...c/modules/quicksearch/services/doc-display-meta.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #7786       +/-   ##
===========================================
- Coverage   55.57%   26.77%   -28.81%     
===========================================
  Files        1002      793      -209     
  Lines       43400    19383    -24017     
  Branches     5146     3588     -1558     
===========================================
- Hits        24121     5190    -18931     
+ Misses      18912    13882     -5030     
+ Partials      367      311       -56     
Flag Coverage Δ
server-test ?
unittest 26.77% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Aug 8, 2024

Merge activity

@EYHN EYHN changed the base branch from graphite-base/7786 to canary August 8, 2024 08:55
@EYHN EYHN force-pushed the eyhn/feat/highlight-doc-title branch from 4fc0ce7 to c7aabd3 Compare August 8, 2024 08:57
@graphite-app graphite-app bot merged commit c7aabd3 into canary Aug 8, 2024
33 checks passed
@graphite-app graphite-app bot deleted the eyhn/feat/highlight-doc-title branch August 8, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants