Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component): modal overlap issue #7691

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Aug 1, 2024

No description provided.

Copy link

graphite-app bot commented Aug 1, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@EYHN EYHN marked this pull request as ready for review August 1, 2024 07:51
Copy link
Member Author

EYHN commented Aug 1, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @EYHN and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Aug 1, 2024

@EYHN EYHN changed the title fix(modal): modal overlap issue fix(core): modal overlap issue Aug 1, 2024
@EYHN EYHN changed the title fix(core): modal overlap issue fix(component): modal overlap issue Aug 1, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 11.42857% with 31 lines in your changes missing coverage. Please review.

Project coverage is 27.55%. Comparing base (33fc00f) to head (bb767a6).

Files Patch % Lines
packages/frontend/component/src/ui/modal/modal.tsx 11.42% 31 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #7691       +/-   ##
===========================================
- Coverage   56.60%   27.55%   -29.05%     
===========================================
  Files         950      742      -208     
  Lines       42298    18423    -23875     
  Branches     4912     3361     -1551     
===========================================
- Hits        23942     5077    -18865     
+ Misses      17994    13040     -4954     
+ Partials      362      306       -56     
Flag Coverage Δ
server-test ?
unittest 27.55% <11.42%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Aug 1, 2024

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants