Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: journal doc title in at menu #7608

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

akumatus
Copy link
Member

@akumatus akumatus commented Jul 26, 2024

Fix issue BS-900.

What Changed?

  • Add i18n for journal doc title and empty doc title.

Copy link

graphite-app bot commented Jul 26, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @akumatus and the rest of your teammates on Graphite Graphite

@akumatus akumatus marked this pull request as ready for review July 26, 2024 03:26
Copy link

nx-cloud bot commented Jul 26, 2024

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 28.87%. Comparing base (470262d) to head (b26b0c3).

Files Patch % Lines
...e/block-suite-editor/specs/custom/linked-widget.ts 0.00% 9 Missing ⚠️
...ore/src/components/affine/reference-link/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #7608       +/-   ##
===========================================
- Coverage   57.79%   28.87%   -28.92%     
===========================================
  Files         914      709      -205     
  Lines       40987    17152    -23835     
  Branches     4625     3084     -1541     
===========================================
- Hits        23687     4953    -18734     
+ Misses      16949    11900     -5049     
+ Partials      351      299       -52     
Flag Coverage Δ
server-test ?
unittest 28.87% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Jul 26, 2024

Merge activity

Fix issue [BS-900](https://linear.app/affine-design/issue/BS-900).

### What Changed?
- Add i18n for journal doc title and empty doc title.
@akumatus akumatus force-pushed the fix/journale-title-in-at-menu branch from 8c812c3 to b26b0c3 Compare July 26, 2024 04:21
@graphite-app graphite-app bot merged commit b26b0c3 into canary Jul 26, 2024
32 checks passed
@graphite-app graphite-app bot deleted the fix/journale-title-in-at-menu branch July 26, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants