Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): adjust app-sidebar z-index #7523

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Conversation

CatsJuice
Copy link
Member

fix AF-1071

Copy link

graphite-app bot commented Jul 17, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Jul 17, 2024

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.65%. Comparing base (e97ac11) to head (b5e8379).
Report is 2 commits behind head on canary.

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #7523   +/-   ##
=======================================
  Coverage   57.65%   57.65%           
=======================================
  Files         908      908           
  Lines       40174    40174           
  Branches     4551     4551           
=======================================
  Hits        23161    23161           
  Misses      16660    16660           
  Partials      353      353           
Flag Coverage Δ
server-test 78.48% <ø> (ø)
unittest 29.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CatsJuice CatsJuice marked this pull request as ready for review July 17, 2024 08:25
@graphite-app graphite-app bot requested review from EYHN, JimmFly, pengx17 and forehalo and removed request for EYHN July 17, 2024 08:26
Copy link
Member

@JimmFly JimmFly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this change work well on smaller screens?

Copy link
Member Author

Will this change work well on smaller screens?

Should already be handled here:

@forehalo forehalo merged commit ade8db2 into canary Jul 17, 2024
35 checks passed
@forehalo forehalo deleted the catsjuice/fix/sidebar-z-index branch July 17, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants