Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: telemetry property names #7468

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Jul 11, 2024

No description provided.

Copy link

graphite-app bot commented Jul 11, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@pengx17 pengx17 marked this pull request as ready for review July 11, 2024 02:20
Copy link
Collaborator Author

pengx17 commented Jul 11, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Jul 11, 2024

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 57.65%. Comparing base (2f441d9) to head (7a35b78).

Files Patch % Lines
.../block-suite-editor/specs/custom/spec-patchers.tsx 0.00% 3 Missing ⚠️
...d/core/src/modules/telemetry/services/telemetry.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7468      +/-   ##
==========================================
- Coverage   57.70%   57.65%   -0.05%     
==========================================
  Files         913      913              
  Lines       40023    40023              
  Branches     4517     4516       -1     
==========================================
- Hits        23095    23076      -19     
- Misses      16583    16602      +19     
  Partials      345      345              
Flag Coverage Δ
server-test 78.46% <ø> (-0.08%) ⬇️
unittest 28.90% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Jul 11, 2024

Merge activity

@pengx17 pengx17 force-pushed the 07-11-fix_telemetry_property_names branch from 0cfeab8 to 7a35b78 Compare July 11, 2024 02:35
@graphite-app graphite-app bot merged commit 7a35b78 into canary Jul 11, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 07-11-fix_telemetry_property_names branch July 11, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants