Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid date handling #7422

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Jul 4, 2024

fix AF-1049

Copy link

graphite-app bot commented Jul 4, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added mod:i18n Related to i18n test Related to test cases labels Jul 4, 2024
Copy link
Collaborator Author

pengx17 commented Jul 4, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@pengx17 pengx17 marked this pull request as ready for review July 4, 2024 02:36
Copy link

nx-cloud bot commented Jul 4, 2024

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.80%. Comparing base (d6ad7d5) to head (5c1f78a).

Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #7422       +/-   ##
===========================================
- Coverage   57.27%   28.80%   -28.47%     
===========================================
  Files         902      702      -200     
  Lines       39626    16696    -22930     
  Branches     4471     2991     -1480     
===========================================
- Hits        22695     4810    -17885     
+ Misses      16584    11589     -4995     
+ Partials      347      297       -50     
Flag Coverage Δ
server-test ?
unittest 28.80% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Jul 4, 2024

Merge activity

@forehalo forehalo force-pushed the 07-04-fix_invalid_date_handling branch from 02f9648 to 5c1f78a Compare July 4, 2024 07:11
@graphite-app graphite-app bot merged commit 5c1f78a into canary Jul 4, 2024
33 checks passed
@graphite-app graphite-app bot deleted the 07-04-fix_invalid_date_handling branch July 4, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod:i18n Related to i18n test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants