Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide find in page command in cmdk #7413

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Jul 2, 2024

No description provided.

Copy link
Collaborator Author

pengx17 commented Jul 2, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

Copy link

graphite-app bot commented Jul 2, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@pengx17 pengx17 marked this pull request as ready for review July 2, 2024 15:38
@graphite-app graphite-app bot requested review from EYHN, forehalo, CatsJuice and JimmFly and removed request for forehalo and EYHN July 2, 2024 15:38
Copy link

nx-cloud bot commented Jul 2, 2024

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.91%. Comparing base (ef7ba27) to head (fc729d6).

Additional details and impacted files
@@             Coverage Diff             @@
##           canary    #7413       +/-   ##
===========================================
- Coverage   57.29%   28.91%   -28.38%     
===========================================
  Files         902      702      -200     
  Lines       39421    16656    -22765     
  Branches     4426     2971     -1455     
===========================================
- Hits        22586     4816    -17770     
+ Misses      16480    11538     -4942     
+ Partials      355      302       -53     
Flag Coverage Δ
server-test ?
unittest 28.91% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the 07-02-fix_hide_find_in_page_command_in_cmdk branch from eae017c to fc729d6 Compare July 2, 2024 15:48
Copy link

graphite-app bot commented Jul 2, 2024

Merge activity

@graphite-app graphite-app bot merged commit fc729d6 into canary Jul 2, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 07-02-fix_hide_find_in_page_command_in_cmdk branch July 2, 2024 15:59
forehalo pushed a commit that referenced this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants