Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cmd-k keybinding not show when editor input is active #7398

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Jul 1, 2024

fix AF-1023

Copy link

graphite-app bot commented Jul 1, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@pengx17 pengx17 marked this pull request as ready for review July 1, 2024 11:18
Copy link
Collaborator Author

pengx17 commented Jul 1, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Jul 1, 2024

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.27%. Comparing base (39acb51) to head (ab621cc).
Report is 2 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7398      +/-   ##
==========================================
- Coverage   58.27%   58.27%   -0.01%     
==========================================
  Files         856      856              
  Lines       37725    37725              
  Branches     4088     4088              
==========================================
- Hits        21985    21984       -1     
- Misses      15447    15448       +1     
  Partials      293      293              
Flag Coverage Δ
server-test 77.99% <ø> (ø)
unittest 28.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EYHN EYHN merged commit 8c4a42f into canary Jul 1, 2024
35 checks passed
@EYHN EYHN deleted the xp/07-01-fix_cmd-k_keybinding_not_show_when_editor_input_is_active branch July 1, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants