feat(web): improve keyboard navigation in RootAppSidebar

[SevenOutman]

Changes:

• Make "Select workspace" button accessible via keyboard navigation
• Make "Quick Search" button accessible via keyboard navigation
• Correct the tab order of "Favorites" link and the "Toggle" button inside of it

Before

AFFiNE.keyboard.navigation.in.sidebar.mov

After

AFFiNE.improved.keyboard.navigation.in.sidebar.mov

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
affine-preview	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 8, 2023 5:33am
affine-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 8, 2023 5:33am

[codecov]

Codecov Report

Patch coverage: 22.22% and project coverage change: -0.02 ⚠️

Comparison is base (d408a8b) 71.60% compared to head (922bc81) 71.59%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2256      +/-   ##
==========================================
- Coverage   71.60%   71.59%   -0.02%     
==========================================
  Files         297      297              
  Lines        6583     6591       +8     
  Branches     1072     1074       +2     
==========================================
+ Hits         4714     4719       +5     
- Misses       1670     1673       +3     
  Partials      199      199              

Flag	Coverage Δ
e2etest	69.13% <22.22%> (-0.02%)	⬇️
server-test	73.14% <ø> (ø)
storybook-test	55.08% <ø> (+0.23%)	⬆️
unittest	36.94% <ø> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...nents/pure/workspace-slider-bar/favorite/index.tsx	88.88% <0.00%> (ø)
...ponents/pure/workspace-slider-bar/shared-styles.ts	100.00% <ø> (ø)
...slider-bar/WorkspaceSelector/WorkspaceSelector.tsx	60.00% <25.00%> (-23.34%)	⬇️
apps/web/src/components/root-app-sidebar/index.tsx	75.00% <25.00%> (-8.34%)	⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[himself65]

perf means performance

[SevenOutman]

perf means performance

@himself65 I consider accessibility as performance as well. It's not a feature nor a fix to me. What other type would you suggest?

[himself65]