Skip to content

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Apr 18, 2023

No description provided.

@JimmFly JimmFly requested a review from himself65 April 18, 2023 05:20
@vercel
Copy link

vercel bot commented Apr 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview Apr 18, 2023 5:34am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2023 5:34am

@JimmFly JimmFly temporarily deployed to development April 18, 2023 05:20 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 18, 2023 05:20 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 18, 2023 05:20 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 18, 2023 05:20 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 18, 2023 05:20 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 18, 2023 05:20 — with GitHub Actions Inactive
@github-actions github-actions bot added app:web mod:i18n Related to i18n labels Apr 18, 2023
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 18, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e0834e4
Status: ✅  Deploy successful!
Preview URL: https://cf7c508b.affine.pages.dev
Branch Preview URL: https://chore-add-translation-for-lo.affine.pages.dev

View logs

@JimmFly JimmFly temporarily deployed to development April 18, 2023 05:21 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 18, 2023 05:21 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 18, 2023 05:21 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 18, 2023 05:21 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 18, 2023 05:21 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 18, 2023 05:21 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 18, 2023 05:23 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch coverage: 83.33% and project coverage change: -0.05 ⚠️

Comparison is base (18223c2) 75.37% compared to head (e0834e4) 75.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2001      +/-   ##
==========================================
- Coverage   75.37%   75.32%   -0.05%     
==========================================
  Files         278      278              
  Lines        5373     5379       +6     
  Branches     1041     1035       -6     
==========================================
+ Hits         4050     4052       +2     
- Misses       1086     1091       +5     
+ Partials      237      236       -1     
Flag Coverage Δ
e2etest 74.51% <83.33%> (-0.06%) ⬇️
storybook-test 50.63% <ø> (ø)
unittest 45.59% <ø> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apps/web/src/components/pure/help-island/index.tsx 85.71% <ø> (ø)
...web/src/pages/workspace/[workspaceId]/[pageId].tsx 72.22% <60.00%> (+1.06%) ⬆️
apps/web/src/layouts/workspace-layout.tsx 87.64% <100.00%> (+0.70%) ⬆️
apps/web/src/pages/index.tsx 87.09% <100.00%> (+0.43%) ⬆️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@perfsee
Copy link

perfsee bot commented Apr 18, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …n-for-loading                 +/- ##
===================================================================
< Bundle              4.27 MB        4.27 MB      +525 B(+0.01%)   
< Initial JS          1.89 MB        1.89 MB      +525 B(+0.03%)   
= Initial CSS         3.13 kB        3.13 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   41             41                       
= Chunks                   39             39                       
= Packages                162            162                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …n-for-loading                 +/- ##
===================================================================
< Bundle              4.17 MB        4.17 MB      +525 B(+0.01%)   
< Initial JS          1.79 MB        1.79 MB      +525 B(+0.03%)   
= Initial CSS         3.13 kB        3.13 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   39             39                       
= Chunks                   37             37                       
= Packages                162            162                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …n-for-loading                 +/- ##
===================================================================
= Bundle              16.7 kB        16.7 kB                       
= Initial JS          16.7 kB        16.7 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@JimmFly JimmFly temporarily deployed to development April 18, 2023 05:27 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 18, 2023 05:27 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 18, 2023 05:27 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 18, 2023 05:27 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 18, 2023 05:30 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 18, 2023 05:34 Inactive
@himself65 himself65 merged commit 346484e into master Apr 18, 2023
@himself65 himself65 deleted the chore/add-translation-for-loading branch April 18, 2023 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:web mod:i18n Related to i18n
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants