fix(core): resolve unexpected forwardRef warning (#7527)

toeverything · Jul 17, 2024 · db35337 · db35337
1 parent 4868f6e
commit db35337
Showing 1 changed file with 21 additions and 13 deletions.
diff --git a/packages/frontend/core/src/modules/workbench/view/view-islands.tsx b/packages/frontend/core/src/modules/workbench/view/view-islands.tsx
@@ -186,13 +186,17 @@ export const ViewSidebarTab = ({
 };
 
 export const ViewSidebarTabIconTarget = forwardRef(
-  function ViewSidebarTabIconTarget({
-    viewId,
-    tabId,
-    ...otherProps
-  }: React.HTMLProps<HTMLDivElement> & { tabId: string; viewId: string }) {
+  function ViewSidebarTabIconTarget(
+    {
+      viewId,
+      tabId,
+      ...otherProps
+    }: React.HTMLProps<HTMLDivElement> & { tabId: string; viewId: string },
+    ref: Ref<HTMLDivElement>
+  ) {
     return (
       <ViewIslandTarget
+        ref={ref}
         id={`${viewId}:sidebar:${tabId}:icon`}
         {...otherProps}
       />
@@ -201,16 +205,20 @@ export const ViewSidebarTabIconTarget = forwardRef(
 );
 
 export const ViewSidebarTabBodyTarget = forwardRef(
-  function ViewSidebarTabBodyTarget({
-    viewId,
-    tabId,
-    ...otherProps
-  }: React.HTMLProps<HTMLDivElement> & {
-    tabId: string;
-    viewId: string;
-  }) {
+  function ViewSidebarTabBodyTarget(
+    {
+      viewId,
+      tabId,
+      ...otherProps
+    }: React.HTMLProps<HTMLDivElement> & {
+      tabId: string;
+      viewId: string;
+    },
+    ref: Ref<HTMLDivElement>
+  ) {
     return (
       <ViewIslandTarget
+        ref={ref}
         id={`${viewId}:sidebar:${tabId}:body`}
         {...otherProps}
       />