Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assets folder for a cleanier app folder hiearchy #8

Merged
merged 1 commit into from
Sep 20, 2013

Conversation

jpsirois
Copy link
Contributor

This make it easier to maintain than having all in the same app root folder.

@noahbass
Copy link
Contributor

👍

@toddmotto
Copy link
Owner

Have always debated this one, think it depends on the size of the project - though we can assume for the most part it'd be cleaner to contain the folders in an assets folder. I'll merge this with the next update as well as the other kind pull requests - thank you for contributing!

@jpsirois
Copy link
Contributor Author

I’ve been between the two schools for a long time. But for the last few projects I’ve been working on, I always find it easier to have only one kind of file/ressources in a folder. I find it easier to find what you’re looking for when there only templates on the root folder for example. We could also have move the favicon and the apple-touch-icon in the asset folder by referencing them, but I like when we didn’t had to declare them in the head of your page.

@toddmotto
Copy link
Owner

Yeah, agreed. On our AngularJS projects it's easier to have assets, views, templates folders then there's no confusion and cleaner to see. I thought about moving the icons across, but then that adds more markup for really no reason at all. Am set on that for now at least, H5BP is pushing that route too.

toddmotto added a commit that referenced this pull request Sep 20, 2013
Add `assets` folder for a cleanier `app` folder hierarchy
@toddmotto toddmotto merged commit 183d33b into toddmotto:master Sep 20, 2013
@jpsirois jpsirois deleted the assets-folder branch September 20, 2013 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants