chore: add cloudflare deploy script wrapper, add post-deploy smoke check, run TS helper scripts with tsx#47
Closed
toddeTV wants to merge 5 commits into
Closed
Conversation
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/cloudflare-deploy.yml:
- Around line 58-61: Replace the hardcoded CLOUDFLARE_PAGES_PROJECT_NAME value
with the GitHub Variable mapping; update the workflow env entry for
CLOUDFLARE_PAGES_PROJECT_NAME to use ${{ vars.CLOUDFLARE_PAGES_PROJECT_NAME }}
so it follows the repo's env-var naming convention (match .env.example) instead
of the literal "todde-tv".
- Around line 63-73: The post-deploy-smoke-test job currently only runs the
command "vp run verify:cloudflare:smoke" in the "Verify public routes" step;
update the job to first checkout the repo, install/setup the vp CLI, and install
project dependencies before running that command. Specifically add an
actions/checkout step, a step to install or setup "vp" (or use the appropriate
setup action/binary install for vp), and a dependency install step (e.g., npm ci
/ pnpm install / yarn install matching the project) placed before the step that
runs "vp run verify:cloudflare:smoke", ensuring the "Verify public routes" step
runs in a checked-out workspace with vp available and dependencies installed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
Run ID: f8b72e50-1752-409e-97c1-a0c674365b4e
📒 Files selected for processing (5)
.github/workflows/cloudflare-deploy.ymlpackage.jsonscripts/check-cloudflare-smoke.tsscripts/deploy-cloudflare.tsscripts/generate-redirects.ts
toddeTV
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
toddeTV
force-pushed
the
fix/cloudflare-deploy-wrapper-and-smoke-check
branch
from
c9aa4ba to
ea98e38
Compare
|
Caution Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted. Error details |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/cloudflare-deploy.yml (1)
70-89: ⚡ Quick winParameterize smoke-test base URL to avoid deploy/verify drift.
The smoke check currently targets a fixed URL, while the deploy target is configurable. This can validate the wrong site if project/domain config changes.
Proposed change
- name: Verify public routes env: - BASE_URL: https://todde.tv + BASE_URL: ${{ vars.CLOUDFLARE_SMOKE_BASE_URL != '' && vars.CLOUDFLARE_SMOKE_BASE_URL || 'https://todde.tv' }} run: vp run verify:cloudflare:smoke🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/cloudflare-deploy.yml around lines 70 - 89, Replace the hardcoded BASE_URL used for the smoke check with a parameterized value derived from the workflow/deploy configuration (e.g., a workflow input, environment variable, or previous job output) so the smoke test targets the same deploy target; update the job step that sets env BASE_URL and the "vp run verify:cloudflare:smoke" invocation to consume that variable (replace the literal BASE_URL=https://todde.tv with BASE_URL from the workflow input/env/output) and document the new input/env name so deploy and verify remain in sync.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/cloudflare-deploy.yml:
- Around line 70-89: Replace the hardcoded BASE_URL used for the smoke check
with a parameterized value derived from the workflow/deploy configuration (e.g.,
a workflow input, environment variable, or previous job output) so the smoke
test targets the same deploy target; update the job step that sets env BASE_URL
and the "vp run verify:cloudflare:smoke" invocation to consume that variable
(replace the literal BASE_URL=https://todde.tv with BASE_URL from the workflow
input/env/output) and document the new input/env name so deploy and verify
remain in sync.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
Run ID: ede2a756-09e4-4ee9-9fe2-b645574db63a
📒 Files selected for processing (1)
.github/workflows/cloudflare-deploy.yml
Owner
Author
|
Problems with CodeRabbit. I will close this PR and re-create it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Chores