Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(mysql): delete redundant keywords #3646

Merged
merged 23 commits into from
Jun 13, 2024
Merged

Fix(mysql): delete redundant keywords #3646

merged 23 commits into from
Jun 13, 2024

Conversation

Toms1999
Copy link
Contributor

I found some repetitions in the RESERVED_KEYWORDS for mysql dialect, and I checked the relevant pr to make sure it was indeed repetitions and not something else

Toms1999 and others added 23 commits May 24, 2024 15:45
@Toms1999
Feat(bigquery,presto): improve transpilation of INTERVAL (plural to s…
c74397e 
…ingular)
@Toms1999
Feat(bigquery,presto): improve transpilation of INTERVAL (plural to s…
dab3927 
…ingular)
@Toms1999
Feat(bigquery,presto): improve transpilation of INTERVAL (plural to s…
ae029d8 
…ingular)
@Toms1999
Merge branch 'tobymao:main' into main
6e7c362
@Toms1999
fix(doris) , mysql group_concat function different doris , it is not …
c24e81d 
…support separator keyword
@Toms1999
fix(doris) , mysql group_concat function different doris , it is not …
b93aae3 
…support separator keyword
@Toms1999
fix(doris) , mysql group_concat function different doris , it is not …
5ff3be2 
…support separator keyword
@Toms1999
fix(doris) , mysql group_concat function different doris , it is not …
4c331da 
…support separator keyword
@Toms1999
fix(doris) , mysql group_concat function different doris , it is not …
7c0ea61 
…support separator keyword
@georgesittas
Update tests/dialects/test_doris.py
8cf4e29
@georgesittas
Update sqlglot/dialects/doris.py
a3a9ab2
@georgesittas
Update sqlglot/dialects/doris.py
0f95c95
@georgesittas
Update sqlglot/dialects/doris.py
40147e7
@Toms1999
fix(presto to hive) , TIMESTAMP_TRUNC function to trunc function
4d2d56b
@Toms1999
Merge remote-tracking branch 'origin/main'
4b516eb
@Toms1999
Merge remote-tracking branch 'origin/main'
c5d93d0 
# Conflicts:
#	tests/dialects/test_doris.py
@Toms1999
fix(presto to hive) , TIMESTAMP_TRUNC function to trunc function
472ca6e
@Toms1999
fix(presto keyword) DIV
9f874ea
@Toms1999
Merge remote-tracking branch 'origin/main'
6ec1f03 
# Conflicts:
#	sqlglot/dialects/hive.py
#	tests/dialects/test_hive.py
@Toms1999
Merge remote-tracking branch 'origin/main'
f24e08c
@Toms1999
fix (mysql) delete redundant keywords
bd1eb80
@Toms1999
Merge remote-tracking branch 'origin/main'
461de17
@Toms1999
github
9a00c4f
@Toms1999 Toms1999 marked this pull request as ready for review June 13, 2024 06:51
georgesittas
georgesittas approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@georgesittas georgesittas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@georgesittas georgesittas changed the title fix (mysql) delete redundant keywords Fix(mysql): delete redundant keywords Jun 13, 2024
@georgesittas georgesittas merged commit 88c4965 into tobymao:main Jun 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgesittas georgesittas georgesittas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Toms1999 @georgesittas