-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: stdout is bytes on python3 #272
base: master
Are you sure you want to change the base?
Conversation
Conflicts: example/templates/base.html
Update default baseline Increase width of second graph
tilt xlabels on Plot 2
test, fix angling x-axis on cpythonplot2
Merge latest codespeed/master from upstream into speed.pypy.org
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no tests currently for the mercurial module. It'd be awesome to add at least one for the happy path, but it is not a must for this PR if you don't have the time.
codespeed/commits/mercurial.py
Outdated
@@ -63,7 +63,7 @@ def getlogs(endrev, startrev): | |||
if p.returncode != 0: | |||
raise CommitLogError(str(stderr)) | |||
else: | |||
stdout = stdout.rstrip('\n') # Remove last newline | |||
stdout = str(stdout.rstrip(b'\n')) # Remove last newline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stdout = str(stdout).rstrip('\n')
looks clearer to me.
how do I run the tests?
|
It's not configured to run with |
I need to get used to django unit tests. For instance, I am used to the testing framework supplying a tmp_dir so that I could set up a hg/git repo, but spent quite a while searching for the recommended way to do this in django so that the directory is erased when tests finish. Any hints? OTOH, it seems like a lot of work to set up testing for a small fix... |
An example of how to do this with django tests: |
BUG: stdout is bytes, convert to str
need to decode. Test added |
discovered on speed.pypy.org
Where should I add a test?