Allow partial requests of timeline grid #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Marr <[email protected]>
- add helper method to read setting with default value if not present Signed-off-by: Stefan Marr <[email protected]>
The page size is configurable as a setting. Streaming is used to be able to already send data to the client while more database query my still need to be performed. timeline.js will keep requesting data as long as the nextBenchmarks field indicates an indicates (!== false). The plotgrid is only reset on the first request. Signed-off-by: Stefan Marr <[email protected]>
tobami
approved these changes
Nov 2, 2018
codespeed/views.py
Outdated
| return number_of_revs, benchmarks | ||
|
|
||
|
|
||
| def get_stats_with_defaults(res): |
There was a problem hiding this comment.
Nice factoring this functions out of the views! They could be moved out of the views module
There was a problem hiding this comment.
Yeah, indeed, good point. Where would you want them to be? Not sure it fits into the model?
There was a problem hiding this comment.
view_data sounded like a good fit. So, I pushed 503beb5 and moved both helper functions there.
Signed-off-by: Stefan Marr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to request the timeline view in multiple "pages".
It introduces two settings:
TIMELINE_GRID_LIMITis used to decide whether to show the grid or automatically disable it if there are more than the configured benchmarksTIMELINE_GRID_PAGINGallows to set the number of benchmarks fetched in one goI kept the underlying feature of TIMELINE_GRID_LIMIT to be able to disable the automatic fetching for the grid view.
This change also uses
StreamingHttpResponseto start sending data as soon as it is ready, while still other database queries my need to be performed. This is likely only useful for large values ofTIMELINE_GRID_PAGING.The user interface should be unchanged.
This should resolve #254.