Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some modernization of the UI #205

Merged
merged 5 commits into from
Jul 18, 2016
Merged

Conversation

javierhonduco
Copy link
Contributor

Several visual improvements have been done in this PR.
Most of them are tiny but they make the experience of using codespeed significantly better IMO.

  • Modernized visuals related to the border-radius attribute.
  • Move on to html5.
  • Usage of Arial as the default font.
  • Removal of some images such as the background one and the loading gif and the warning sign that has been replaced by its unicode counterpart.
  • Shadow removal from mosts graphs. The ones from bars and container boxes.
  • Added some vim and OSX-specific files to be ignored.

Things I haven't been able to do and that I would love to have (and if I have some spare time I'll try to do):

  • Get rid of all shadows in graphs and use a consistent font for titles and legends.
  • Replace the current graph library with a more modern one with a nicer API. Not easy at all, but I think it would pay off.
  • JS refactor. (Don't think I'm skilled enough js-wise, but still)
  • Substitute all images with other assets.

Thank you for the project 💟,

@tobami
Copy link
Owner

tobami commented Jul 18, 2016

Nice improvements all around! I agree the look was getting really old, this helps a log, many thanks!

I was thinking along the same lines as you: modernize the design, replace the plotting library, refactor JS and so on. If you want to do any of those that would be great. Which graph library do you have in mind?

@tobami tobami merged commit 5c8d6b3 into tobami:master Jul 18, 2016
@javierhonduco javierhonduco deleted the visual-improvements branch July 19, 2016 22:39
@javierhonduco
Copy link
Contributor Author

It's just a tiny little bit, but glad you liked it. 😄

Yeah, I would love being to work on those things, but ATM cannot work fulltime on that. Will try to contribute with small changes instead.
Probably for the plotting library could be something based on d3? I've seen many that are really nice, complete and have a interesting and simple API.

Another feature that just popped to my mind would be having a realtime feature that alerted you when some new datapoint is introduced, like the one GitHub has whenever a new branch or commits are pushed, but of course that is not trivial to implement in a good way.

@tobami
Copy link
Owner

tobami commented Jul 20, 2016

Hi Javier,

D3 would be a good pick yes. As to the "feature that alerted", you mean
pushing to some webhook, or email notifications? Doesn't RSS work for you?

Small changes are great! You don't need big contributions in order for it
to be helpful.
Btw. may I ask what you are using Codespeed for?

On Wed, Jul 20, 2016 at 12:49 AM Javier Honduvilla Coto <
[email protected]> wrote:

It's just a tiny little bit, but glad you liked it. 😄

Yeah, I would love being to work on those things, but ATM cannot work
fulltime on that. Will try to contribute with small changes instead.
Probably for the plotting library could be something based on d3? I've
seen many that are really nice, complete and have a interesting and simple
API.

Another feature that just popped to my mind would be having a realtime
feature that alerted you when some new datapoint is introduced, like the
one GitHub has whenever a new branch or commits are pushed, but of course
that is not trivial to implement in a good way.


You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub
#205 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AANNpbUl5Y3-usmtjzXNjzGDwoEFbggCks5qXVRtgaJpZM4JOHCA
.

@javierhonduco
Copy link
Contributor Author

It would be nice to have those notifications for when you are viewing a benchmark and it's updated but you are still viewing former results.
Just as a heads up that tells you that new data has arrived.
So it's a different use case from RSS, I'd say :).

It's one of the tools that I was having a look to use for my bachelor thesis, as performance is a key aspect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants