add openvpn::deploy::(export/client)

fix linting, add credit
restructure deploy manifests
fixes voxpupuli#231

lib/facter/openvpn_deploy_cert_data.rb

@@ -0,0 +1,24 @@
+Facter.add("openvpn::deploy_cert_data") do
+  setcode do
+    clients = {}
+    path = '/etc/openvpn'
+    if File.directory?(path)
+      Dir.entries(path).each do |server|
+        if File.directory?("#{path}/#{server}/download-configs")
+          Dir.entries("#{path}/#{server}/download-configs").each do |client|
+            if File.directory?("#{path}/#{server}/download-configs/#{client}") and client !~ /^\.\.?$/ and client !~ /\.tblk$/
+              clients["#{server}-#{client}-conf"] = File.open("#{path}/#{server}/download-configs/#{client}/#{client}.conf", "r").read
+              clients["#{server}-#{client}-ca"] = File.open("#{path}/#{server}/download-configs/#{client}/keys/#{client}/ca.crt", "r").read
+              clients["#{server}-#{client}-crt"] = File.open("#{path}/#{server}/download-configs/#{client}/keys/#{client}/#{client}.crt", "r").read
+              clients["#{server}-#{client}-key"] = File.open("#{path}/#{server}/download-configs/#{client}/keys/#{client}/#{client}.key", "r").read
+              if File.exists?("#{path}/#{server}/download-configs/#{client}/keys/#{client}/ta.key")
+                clients["#{server}-#{client}-ta"] = File.open("#{path}/#{server}/download-configs/#{client}/keys/#{client}/ta.key", "r").read
+              end
+            end
+          end
+        end
+      end
+    end
+    clients
+  end
+end

manifests/client.pp

@@ -258,27 +258,31 @@
     ensure => directory,
   }
 
-  file { "${etc_directory}/openvpn/${server}/download-configs/${name}/keys/${name}/${name}.crt":
+  file { "${server}-${name}-crt":
     ensure  => link,
+    path    => "${etc_directory}/openvpn/${server}/download-configs/${name}/keys/${name}/${name}.crt",
     target  => "${etc_directory}/openvpn/${ca_name}/easy-rsa/keys/${name}.crt",
     require => Exec["generate certificate for ${name} in context of ${ca_name}"],
   }
 
-  file { "${etc_directory}/openvpn/${server}/download-configs/${name}/keys/${name}/${name}.key":
+  file { "${server}-${name}-key":
     ensure  => link,
+    path    => "${etc_directory}/openvpn/${server}/download-configs/${name}/keys/${name}/${name}.key",
     target  => "${etc_directory}/openvpn/${ca_name}/easy-rsa/keys/${name}.key",
     require => Exec["generate certificate for ${name} in context of ${ca_name}"],
   }
 
-  file { "${etc_directory}/openvpn/${server}/download-configs/${name}/keys/${name}/ca.crt":
+  file { "${server}-${name}-ca":
     ensure  => link,
+    path    => "${etc_directory}/openvpn/${server}/download-configs/${name}/keys/${name}/ca.crt",
     target  => "${etc_directory}/openvpn/${ca_name}/easy-rsa/keys/ca.crt",
     require => Exec["generate certificate for ${name} in context of ${ca_name}"],
   }
 
   if $tls_auth {
-    file { "${etc_directory}/openvpn/${server}/download-configs/${name}/keys/${name}/ta.key":
+    file { "${server}-${name}-ta":
       ensure  => link,
+      path    => "${etc_directory}/openvpn/${server}/download-configs/${name}/keys/${name}/ta.key",
       target  => "${etc_directory}/openvpn/${server}/easy-rsa/keys/ta.key",
       require => Exec["generate certificate for ${name} in context of ${server}"],
       before  => [
@@ -314,7 +318,8 @@
       before  => Exec["tar the thing ${server} with ${name}"];
   }
 
-  file { "${etc_directory}/openvpn/${server}/download-configs/${name}/${name}.conf":
+  file { "${server}-${name}-conf":
+    path    => "${etc_directory}/openvpn/${server}/download-configs/${name}/${name}.conf",
     owner   => root,
     group   => $::openvpn::params::root_group,
     mode    => '0444',

manifests/deploy/client.pp

@@ -0,0 +1,59 @@
+# == Define: openvpn::deploy::client
+#
+# Collect the exported configs for an Host and ensure a running Openvpn Service
+#
+# === Parameters
+#
+# $server   which Openvpn::Server[$server] does the config belong to?
+# String
+#
+# $manage_etc should the /etc/openvpn directory be managed? (warning, all unmanaged files will be purged!)
+#
+# === Variables
+#
+# None
+#
+# === Examples
+#
+#  openvpn::deploy::client { 'test-client':
+#    server => 'test_server',
+#  }
+#
+# === Authors
+#
+# Phil Bayfield https://bitbucket.org/Philio/
+#
+
+define openvpn::deploy::client (
+  String $server,
+  Boolean $manage_etc = true,
+) {
+
+  include openvpn::deploy::prepare
+
+  Class['openvpn::deploy::install']
+  -> Openvpn::Deploy::Client[$name]
+  ~> Class['openvpn::deploy::service']
+
+
+  if ($manage_etc == true) {
+    file { [
+      "${::openvpn::params::etc_directory}/openvpn",
+      "${::openvpn::params::etc_directory}/openvpn/keys",
+      "${::openvpn::params::etc_directory}/openvpn/keys/${name}",
+    ]:
+      ensure  => directory,
+      purge   => true,
+      force   => true,
+      require => Package['openvpn'];
+    }
+  } else {
+    file { "${::openvpn::params::etc_directory}/openvpn/keys/${name}":
+      ensure  => directory,
+      require => Package['openvpn'];
+    }
+  }
+
+  File <<| tag == "${server}-${name}" |>>
+
+}

manifests/deploy/export.pp

@@ -0,0 +1,93 @@
+# == Define: openvpn::deploy::export
+#
+# Prepare all Openvpn-Client-Configs to be exported
+#
+# === Parameters
+#
+# $server   which Openvpn::Server[$server] does the config belong to?
+# String
+#
+# $tls_auth should the ta* files be exported too?
+#
+# === Variables
+#
+# None
+#
+# === Examples
+#
+#  openvpn::deploy::export { 'test-client':
+#    server => 'test_server',
+#  }
+#
+# === Authors
+#
+# Phil Bayfield https://bitbucket.org/Philio/
+#
+
+define openvpn::deploy::export (
+  String $server,
+  Boolean $tls_auth = false,
+) {
+
+  Openvpn::Server[$server]
+  -> Openvpn::Client[$name]
+  -> Openvpn::Deploy::Export[$name]
+
+  if $::openvpn::deploy_cert_data {
+    $data = $::openvpn::deploy_cert_data
+  } else {
+    fail('openvpn::deploy_cert_data not defined, is pluginsync enabled?')
+  }
+
+  @@file { "exported-${server}-${name}-config":
+    ensure  => file,
+    path    => "${::openvpn::params::etc_directory}/openvpn/${name}.conf",
+    owner   => 'root',
+    group   => 'root',
+    mode    => '0600',
+    content => $data["exported-${server}-${name}-conf"],
+    tag     => "${server}-${name}",
+  }
+
+  @@file { "exported-${server}-${name}-ca":
+    ensure  => file,
+    path    => "${::openvpn::params::etc_directory}/openvpn/keys/${name}/ca.crt",
+    owner   => 'root',
+    group   => 'root',
+    mode    => '0600',
+    content => $data["${server}-${name}-ca"],
+    tag     => "${server}-${name}",
+  }
+
+  @@file { "exported-${server}-${name}-crt":
+    ensure  => file,
+    path    => "${::openvpn::params::etc_directory}/openvpn/keys/${name}/${name}.crt",
+    owner   => 'root',
+    group   => 'root',
+    mode    => '0600',
+    content => $data["${server}-${name}-crt"],
+    tag     => "${server}-${name}",
+  }
+
+  @@file { "exported-${server}-${name}-key":
+    ensure  => file,
+    path    => "${::openvpn::params::etc_directory}/openvpn/keys/${name}/${name}.key",
+    owner   => 'root',
+    group   => 'root',
+    mode    => '0600',
+    content => $data["${server}-${name}-key"],
+    tag     => "${server}-${name}",
+  }
+
+  if $tls_auth {
+    @@file { "exported-${server}-${name}-ta":
+      ensure  => file,
+      path    => "${::openvpn::params::etc_directory}/openvpn/keys/${name}/ta.key",
+      owner   => 'root',
+      group   => 'root',
+      mode    => '0600',
+      content => $data["${server}-${name}-ta"],
+      tag     => "${server}-${name}",
+    }
+  }
+}

manifests/deploy/install.pp

@@ -0,0 +1,26 @@
+# == Class: openvpn::deploy::install
+#
+# Installs the Openvpn profile
+#
+# === Parameters
+#
+# None
+#
+# === Variables
+#
+# None
+#
+# === Examples
+#
+#  include openvpn::deploy::install
+#
+# === Authors
+#
+# Phil Bayfield https://bitbucket.org/Philio/
+#
+
+class openvpn::deploy::install {
+
+  ensure_packages(['openvpn'])
+
+}

manifests/deploy/prepare.pp

@@ -0,0 +1,29 @@
+# == Class: openvpn::deploy::prepare
+#
+# Base profile
+#
+# === Parameters
+#
+# None
+#
+# === Variables
+#
+# None
+#
+# === Examples
+#
+#  include openvpn::deploy::prepare
+#
+# === Authors
+#
+# Phil Bayfield https://bitbucket.org/Philio/
+#
+
+class openvpn::deploy::prepare {
+
+  class { 'openvpn::params': }
+
+  class { 'openvpn::deploy::install': }
+  ~> class { 'openvpn::deploy::service': }
+
+}

manifests/deploy/service.pp

@@ -0,0 +1,31 @@
+# == Class: openvpn::deploy::service
+#
+# Base profile
+#
+# === Parameters
+#
+# None
+#
+# === Variables
+#
+# None
+#
+# === Examples
+#
+#  include openvpn::deploy::service
+#
+# === Authors
+#
+# Phil Bayfield https://bitbucket.org/Philio/
+#
+
+class openvpn::deploy::service {
+
+  service { 'openvpn':
+    ensure     => running,
+    enable     => true,
+    hasrestart => true,
+    hasstatus  => true;
+  }
+
+}

spec/classes/openvpn_install_spec.rb

@@ -46,13 +46,6 @@
         it { is_expected.to contain_package('openvpn-auth-ldap') }
         it { is_expected.to contain_package('easy-rsa') }
       end
-
-      context 'stretch' do
-        let(:operatingsystemrelease) { '9.0' }
-
-        it { is_expected.to contain_package('openvpn-auth-ldap') }
-        it { is_expected.to contain_package('easy-rsa') }
-      end
     end
 
     context 'redhat/centos' do

spec/defines/openvpn_server_spec.rb

@@ -118,7 +118,6 @@
     it { is_expected.not_to contain_schedule('renew crl.pem schedule on test_server') }
     it { is_expected.not_to contain_exec('renew crl.pem on test_server') }
     it { is_expected.not_to contain_file('/etc/openvpn/test_server.conf').with_content(%r{^secret}) }
-
     it { is_expected.not_to contain_file('/etc/openvpn/test_server.conf').with_content(%r{verb}) }
     it { is_expected.to contain_file('/etc/openvpn/test_server.conf').with_content(%r{cipher AES-256-CBC}) }
     it { is_expected.not_to contain_file('/etc/openvpn/test_server.conf').with_content(%r{persist-key}) }