fix(load): passthru of tmux config_file #843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
f93179d erroneously renamed the argument for `libtmux.server.Server` which is still called `config_file`.
tony
force-pushed
the
fix/passing-tmux-config-file
branch
from
16cc3b4 to
02cfedd
Compare
tony
reviewed
Oct 31, 2022
tony
previously approved these changes
Oct 31, 2022
Member
tony
left a comment
tony
left a comment
There was a problem hiding this comment.
Well done. Will merge and release
tony
force-pushed
the
fix/passing-tmux-config-file
branch
from
c88b134 to
ab8e776
Compare
Codecov Report
@@ Coverage Diff @@
## master #843 +/- ##
=======================================
Coverage 76.19% 76.19%
=======================================
Files 24 24
Lines 1613 1613
Branches 366 366
=======================================
Hits 1229 1229
Misses 275 275
Partials 109 109
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tony
added a commit
that referenced
this pull request
Oct 31, 2022
Member
|
@zappolowski Well done, and nice job on the test too Released v1.18.1 (GitHub, Tag, PyPI) If you try it out, any better? |
Contributor
Author
|
Works for me now ... sorry for the wrong typing in the test. 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f93179d erroneously renamed the argument for
libtmux.server.Serverwhich is still calledconfig_file.