Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further Save and restore hooks #267

Merged
merged 2 commits into from
Aug 20, 2018
Merged

Further Save and restore hooks #267

merged 2 commits into from
Aug 20, 2018

Conversation

ashb
Copy link
Contributor

@ashb ashb commented Aug 17, 2018

Further to #230 (and based on it, with the same initial commit keeping authorship) but extended to have more hook points.

Closes #230, #213

@ashb ashb changed the title Save restore hooks Further Save and restore hooks Aug 17, 2018
docs/hooks.md Outdated

Called before any tmux state is altered.

- `eresurrect-hook-pre-restore-history`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

docs/hooks.md Outdated

- `eresurrect-hook-pre-restore-history`

Called after panes and layout have been restores, but before bash history is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo ... "have been restored"

docs/hooks.md Outdated
- `eresurrect-hook-pre-restore-history`

Called after panes and layout have been restores, but before bash history is
restored (if it is enabled) -- the hook is always called even is history
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if history ..

docs/hooks.md Outdated

- `@resurrect-hook-pre-restore-pane-processes`

Called after history is resotred, but before running processes are restored.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Called after history is restored"

docs/hooks.md Outdated

Called after history is resotred, but before running processes are restored.

Here is an example how to save and restore window geometry for most terminals in X11.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a header above this line ### Examples

@bruno-
Copy link
Member

bruno- commented Aug 18, 2018

Thanks for working on this, looks good. Please ping me when you fix the typos and I'll merge.

And make the hook calling simpler at the call site.
@ashb
Copy link
Contributor Author

ashb commented Aug 20, 2018

@bruno- typos fixed, thanks!

@bruno- bruno- merged commit 6feae65 into tmux-plugins:master Aug 20, 2018
@ashb ashb deleted the save-restore-hooks branch August 20, 2018 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants