Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color configuration options #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

srathbone
Copy link

I've set the default colors to white so users updating the plugin will have the same colors.

@kristijanhusak
Copy link

@bruno- any chance this gets merged in?

@bruno-
Copy link
Member

bruno- commented Apr 19, 2018

Hey, I don't fully understand why we'd want this feature in this plugin? Can't the user just set the color manually before the #{online_status} interpolation?

@kristijanhusak
Copy link

Yes, but it will be same for both offline and online. Idea here is to have 2 different colors for 2 states, like red for offline, and green for online.

@srathbone
Copy link
Author

srathbone commented Apr 19, 2018

The user could instead do this:-

set -g @online_icon "#[fg=#73d216]✔"
set -g @offline_icon "#[fg=#fc4138]✘"

I'm happy for you to reject the PR but could we put this in the documentation to make it clear to the users how to set custom colours per status?

I could create a new PR to instead add this information to the readme?

@kristijanhusak
Copy link

@srathbone nice, i didn't think of that.

I guess we don't need this then, just an example in readme as you said.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants