Skip to content

Commit

Permalink
Remove patched curv as found the culprit in fs-dkr.
Browse files Browse the repository at this point in the history
The fs-dkr dependency was enabling default-features for curv-kzen which
in turn forced rust-gmp-kzen to be compiled which breaks webassembly.

By switching off default-features we can now force the usage of
num-bigint.
  • Loading branch information
tmpfs committed Mar 7, 2023
1 parent 819bc39 commit 76f95af
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 6 deletions.
5 changes: 3 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 1 addition & 4 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ branch = "deps-update"
#path = "../forks/cggmp-threshold-ecdsa"
default-features = false


[dependencies.curv-kzen]
#git = "https://github.com/ZenGo-X/curv"
#path = "../forks/curv"
Expand All @@ -51,9 +52,5 @@ branch = "deps-update"
default-features = false
version = "*"

[patch.crates-io]
#curv-kzen = { path = "../forks/curv" }
curv-kzen = { git= "https://github.com/tmpfs/curv", branch = "disable-default-features" }

[dev-dependencies]
wasm-bindgen-test = "0.3"
11 changes: 11 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# CGGMP Webassembly

Compiles the [cggmp-threshold-ecdsa][] library to webassembly using some forks which update dependencies to remove conflicts.

Once these PRs are merged then we can revert to the `webb-tools` versions:

1) https://github.com/webb-tools/multi-party-ecdsa/pull/14
2) https://github.com/webb-tools/fs-dkr/pull/12
3) https://github.com/webb-tools/cggmp-threshold-ecdsa/pull/13

[cggmp-threshold-ecdsa]: https://github.com/webb-tools/cggmp-threshold-ecdsa/

0 comments on commit 76f95af

Please sign in to comment.