Skip to content

ECS Support #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 81 commits into from
Jan 15, 2019
Merged

ECS Support #424

merged 81 commits into from
Jan 15, 2019

Conversation

bleggett
Copy link
Contributor

@bleggett bleggett commented Dec 14, 2018

This is the PR to track the merge of the changes to deploy containers to ECS and remove the need for a local Docker instance on the installer box.

This should be merged into develop once it is fully tested and slated for the next release.

bleggett and others added 30 commits August 29, 2018 11:37
Former-commit-id: 5d0f8f1
Docker pull jenkins image

Former-commit-id: e27a64c
Former-commit-id: 7f5cb55
Former-commit-id: f514472
Former-commit-id: 9f56fc5
Hmm
Former-commit-id: 138b448
Former-commit-id: b81cbd4
Former-commit-id: 7bcfd98
:D
Former-commit-id: 3af0b45
Separate Access Key Operational

Former-commit-id: 4eda6e5
IAM permission updated - AWS SQS events

Former-commit-id: e5449d9
Docker creds and rebased events.

Former-commit-id: 7ebfef0
S3 Events - Cloudformation permission updated

Former-commit-id: 6499413
Former-commit-id: f1995f9
rajeevr2715 and others added 3 commits January 14, 2019 16:26
* adding python3 & set alias

* purge unwanted

* Added remove identity policy in destroy script

* Review changes

* followup to remove jenkinsplugins

* Adding golang docker instance

* custom recipe for golang

* removing RUN

* fix Path issues

* Path issue fixed chef recipe

* correct Indentation

* py3 on existing Jenkins

* Updated to stable version to fix the gitlab container issue

* Fixed typo

* Updated python3.6 support
Updated ECS Readme file and resolved conflicts
suryajak
suryajak previously approved these changes Jan 14, 2019
Copy link
Contributor

@suryajak suryajak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the status that was shared, this lgtm.

Copy link
Contributor Author

@bleggett bleggett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I can't approve this because I created the PR.

@@ -0,0 +1,34 @@
#!/bin/bash
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI and for future reference this can be done in about 10 lines of python with the python gitlab library, but I've already done that in the python installer rewrite branch (configure-gitlab.py) so no big deal right for now.

@bleggett bleggett merged commit a8dbcd4 into develop Jan 15, 2019
@rajeevr2715 rajeevr2715 added test-inprogress and removed test-pending Indicates that the PR has not been tested yet labels Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants