Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History functions/methods should not consider the current moment #21

Open
tmedwards opened this issue Jun 5, 2020 · 1 comment
Open
Assignees
Labels
done Issue is resolved investigate Information gathering is needed

Comments

@tmedwards
Copy link
Owner

Idea: The various history functions/methods should not consider the current moment.

Reasoning

Currently, the various history functions/methods—e.g., the visited family of functions and State.hasPlayed()—include the current moment in their tests/collations. This has the effect that testing for the existence of a moment based on the current passage is impossible with most of them, as it'll will be topmost moment that they check. This requires the use of visited() in many case where you simply want to know if the player had been there before, which is less than ideal as it looks at every single moment in the past+expired history.

@tmedwards tmedwards transferred this issue from another repository Aug 2, 2020
@tmedwards tmedwards self-assigned this Aug 2, 2020
@tmedwards tmedwards added investigate Information gathering is needed todo Make this happen labels Aug 2, 2020
@tmedwards tmedwards added this to To do in Pre-alpha Work via automation Aug 2, 2020
@Uzume
Copy link

Uzume commented Oct 21, 2020

It should be noted that even if current state history goes away with #20, this functionality would still be useful across an effectively expired state only history.

@tmedwards tmedwards added done Issue is resolved and removed todo Make this happen labels Jan 31, 2021
@tmedwards tmedwards moved this from To do to Done in Pre-alpha Work Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done Issue is resolved investigate Information gathering is needed
Projects
Development

No branches or pull requests

2 participants