Skip to content

Remove static Signature signature properties. #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmds merged 1 commit into from
Nov 21, 2024
Merged

Remove static Signature signature properties. #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<Import Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.props', '$(MSBuildThisFileDirectory)../'))" />
<PropertyGroup>
<PublishRepositoryUrl>true</PublishRepositoryUrl>
<VersionPrefix>0.21.0</VersionPrefix>
<VersionPrefix>0.21.1</VersionPrefix>
<DeterministicSourcePaths Condition="'$(Configuration)' == 'Release'">true</DeterministicSourcePaths>
</PropertyGroup>
</Project>
28 changes: 14 additions & 14 deletions src/Tmds.DBus.Protocol/Signature.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,20 +5,20 @@ public readonly struct Signature
private readonly byte[]? _value;

// note: C# compiler treats these as static data.
public static ReadOnlySpan<byte> Byte => new byte[] { (byte)'y' };
public static ReadOnlySpan<byte> Boolean => new byte[] { (byte)'b' };
public static ReadOnlySpan<byte> Int16 => new byte[] { (byte)'n' };
public static ReadOnlySpan<byte> UInt16 => new byte[] { (byte)'q' };
public static ReadOnlySpan<byte> Int32 => new byte[] { (byte)'i' };
public static ReadOnlySpan<byte> UInt32 => new byte[] { (byte)'u' };
public static ReadOnlySpan<byte> Int64 => new byte[] { (byte)'x' };
public static ReadOnlySpan<byte> UInt64 => new byte[] { (byte)'t' };
public static ReadOnlySpan<byte> Double => new byte[] { (byte)'d' };
public static ReadOnlySpan<byte> UnixFd => new byte[] { (byte)'h' };
public static ReadOnlySpan<byte> String => new byte[] { (byte)'s' };
public static ReadOnlySpan<byte> ObjectPath => new byte[] { (byte)'o' };
public static ReadOnlySpan<byte> Sig => new byte[] { (byte)'g' }; // Name can not be the same as enclosing type.
public static ReadOnlySpan<byte> Variant => new byte[] { (byte)'v' };
internal static ReadOnlySpan<byte> Byte => new byte[] { (byte)'y' };
internal static ReadOnlySpan<byte> Boolean => new byte[] { (byte)'b' };
internal static ReadOnlySpan<byte> Int16 => new byte[] { (byte)'n' };
internal static ReadOnlySpan<byte> UInt16 => new byte[] { (byte)'q' };
internal static ReadOnlySpan<byte> Int32 => new byte[] { (byte)'i' };
internal static ReadOnlySpan<byte> UInt32 => new byte[] { (byte)'u' };
internal static ReadOnlySpan<byte> Int64 => new byte[] { (byte)'x' };
internal static ReadOnlySpan<byte> UInt64 => new byte[] { (byte)'t' };
internal static ReadOnlySpan<byte> Double => new byte[] { (byte)'d' };
internal static ReadOnlySpan<byte> UnixFd => new byte[] { (byte)'h' };
internal static ReadOnlySpan<byte> String => new byte[] { (byte)'s' };
internal static ReadOnlySpan<byte> ObjectPath => new byte[] { (byte)'o' };
internal static ReadOnlySpan<byte> Sig => new byte[] { (byte)'g' }; // Name can not be the same as enclosing type.
internal static ReadOnlySpan<byte> Variant => new byte[] { (byte)'v' };

internal byte[] Data => _value ?? Array.Empty<byte>();

Expand Down