[Tmds.DBus.Protocol] Don't respond on any method_call - #211
Closed
shimr12 wants to merge 2 commits into
Closed
Conversation
Owner
|
@shimr12 sorry for the unresponsiveness. It's been a busy few weeks for me, but it should be a bit calmer now. What do you think about adding a Its signature would be something like: ValueTask BecomeMonitorAsync(
IEnumerable<MatchRule>? rules,
Action<Exception?, Message, object?> handler,
object? handlerState = null,
bool emitOnCapturedContext = true);Would that be usable for you? If it looks good, do you want to implement it, or do you prefer I look into it? The implementation would include no longer replying to messages when this method got called. |
Author
|
not sure I will find time to do these changes in the next weeks, so would prefer if you could add this change :) |
Owner
|
Closing in favor of #217. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly for a use case of working as a monitor after calling BecomeMonitor.
Responding for these messages as a monitor isn't allowed and causes the dbus service to disconnect us