Do not duplicate ReadAsync in DataAvailable. - #167
Merged
Conversation
Owner
|
Can you change the PR to: Replace what is in the if (!_socket.ReceiveAsync(_waitForData))
{
DataAvailable(null, null);
} |
Contributor
Author
|
That does seem to work, and it makes sense to me. I'll update the PR. |
madewokherd
force-pushed
the
dataavailable_race
branch
from
July 8, 2022 20:43
6056191 to
6d676e7
Compare
Owner
|
Thank you, @madewokherd! |
|
Thank you both for finding and fixing this issue. The effects of this issue gave me an uncomfortable feeling in the last weeks as I had no clue where to search for a reason for the missing events. Very glad that it has been found! |
This was referenced Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #164.