Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document multiline input for devs and users #59

Merged
merged 3 commits into from
Oct 1, 2020
Merged

Document multiline input for devs and users #59

merged 3 commits into from
Oct 1, 2020

Conversation

yajo
Copy link
Contributor

@yajo yajo commented Sep 25, 2020

For devs, this feature, that was already working, is now documented.

For users, a default instruction text appears when using multiline mode.

Fix #54.

@yajo yajo mentioned this pull request Sep 25, 2020
@kiancross
Copy link
Collaborator

Thanks for the PR. There's a few tests failing and also you need to run black . over the code, to ensure the formatting is correct.

@kiancross
Copy link
Collaborator

Thanks for fixing code style. Final thing is a couple of tests to make sure the following lines are covered:
https://coveralls.io/builds/33727110/source?filename=questionary%2Fprompts%2Ftext.py#L63

questionary/prompts/text.py Outdated Show resolved Hide resolved
@kiancross kiancross requested a review from tmbo September 25, 2020 17:26
questionary/prompts/text.py Outdated Show resolved Hide resolved
questionary/prompts/text.py Show resolved Hide resolved
tests/test_question.py Show resolved Hide resolved
@kiancross kiancross added Awaiting response Additional information is required Documentation Enhancement New feature or request labels Sep 27, 2020
@yajo
Copy link
Contributor Author

yajo commented Sep 27, 2020

I had to fix one problem on your tests: you were using \n as the Enter key, while it is \r instead. Also another problem in my test. It should go ✔️ now.

yajo and others added 3 commits September 27, 2020 11:01
For devs, this feature, that was already working, is now documented.

For users, a default instruction text appears when using multiline mode.
@kiancross kiancross removed the Awaiting response Additional information is required label Sep 27, 2020
@yajo
Copy link
Contributor Author

yajo commented Oct 1, 2020

So, could this be merged?

@kiancross
Copy link
Collaborator

@yajo Waiting to see what @tmbo thinks about leaving this as the same type vs creating a new one.

@kiancross kiancross self-requested a review October 1, 2020 20:20
@kiancross kiancross merged commit 5b8b6de into tmbo:master Oct 1, 2020
@yajo yajo deleted the patch-1 branch October 4, 2020 07:29
@yajo
Copy link
Contributor Author

yajo commented Oct 6, 2020

According to the new rules for Hacktoberfest 2020:

Pull requests labelled as hacktoberfest-accepted will count toward to Hacktoberest from any public repository on GitHub

So may I ask you please to label this PR as hacktoberfest-accepted? 🙏 🥺

@yajo yajo mentioned this pull request Oct 6, 2020
6 tasks
@kiancross
Copy link
Collaborator

So may I ask you please to label this PR as hacktoberfest-accepted?

@tmbo Can you check this?

@tmbo
Copy link
Owner

tmbo commented Oct 14, 2020

already added it to the repository 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiline input
3 participants