Skip to content

Conversation

kriskwiatkowski
Copy link
Collaborator

@kriskwiatkowski kriskwiatkowski commented Sep 21, 2025

  • Added new section called Discussion and moved FIPS-compliance and Failures text there.
  • Removed Construction section.
  • Various cosmetic changes

The second goal is to release new version to avoid document expiration (in 2 days).

* Added new section called Discussion and moved FIPS-compliance and Failures text there.
* Removed Construction section.
* Various cosmetic changes
Copy link

@dconnolly dconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just one suggested change around mentioning the teeny tiny chance of mlkem decaps/encaps failure

Copy link
Collaborator

@csosto-pk csosto-pk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, I had some small text updates. Nothing too drastic.

@kriskwiatkowski kriskwiatkowski force-pushed the kris/align_with_hybrid_design_16 branch from c1d19c0 to 0614550 Compare September 23, 2025 23:17
@kriskwiatkowski kriskwiatkowski force-pushed the kris/align_with_hybrid_design_16 branch from c0909a8 to bf8fbf2 Compare September 23, 2025 23:53
kriskwiatkowski and others added 3 commits September 24, 2025 15:08
Text has no references to Xyber anymore, hence I assume it can be removed.
@kriskwiatkowski kriskwiatkowski force-pushed the kris/align_with_hybrid_design_16 branch from 8d29b28 to 231772d Compare September 25, 2025 16:01
@kriskwiatkowski
Copy link
Collaborator Author

Alright, I believe all comments have now been addressed. I’ll keep an eye on the mailing list discussion regarding KEM decapsulation failures, but otherwise, if there are no further remarks, I suggest we go ahead and merge this PR.

It would also be a good idea to publish the next version of this document and invite potential feedback from the mailing list. I'll try to take care of it.

@seanturner
Copy link
Collaborator

Give people a couple of days and then go ahead and submit a new version. The I-D has expired and we definitely need a non-expired I-D before November's meeting.

@kriskwiatkowski
Copy link
Collaborator Author

No new comments received, so I've submitted -01.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants