-
Notifications
You must be signed in to change notification settings - Fork 8
Alignment with the newest version of draft-ietf-tls-hybrid-design #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
* Added new section called Discussion and moved FIPS-compliance and Failures text there. * Removed Construction section. * Various cosmetic changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just one suggested change around mentioning the teeny tiny chance of mlkem decaps/encaps failure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, I had some small text updates. Nothing too drastic.
Co-authored-by: Deirdre Connolly <[email protected]>
c1d19c0
to
0614550
Compare
Co-authored-by: Eric Rescorla <[email protected]>
c0909a8
to
bf8fbf2
Compare
Text has no references to Xyber anymore, hence I assume it can be removed.
8d29b28
to
231772d
Compare
Alright, I believe all comments have now been addressed. I’ll keep an eye on the mailing list discussion regarding KEM decapsulation failures, but otherwise, if there are no further remarks, I suggest we go ahead and merge this PR. It would also be a good idea to publish the next version of this document and invite potential feedback from the mailing list. I'll try to take care of it. |
Give people a couple of days and then go ahead and submit a new version. The I-D has expired and we definitely need a non-expired I-D before November's meeting. |
No new comments received, so I've submitted |
The second goal is to release new version to avoid document expiration (in 2 days).