-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It seems that the -outputFile option is not working #103
Comments
I just tested it on my machine - there it seemed to work in general. Maybe it's an issue that only pops up on specific hosts - can you share what you were scanning? Otherwise can you share the whole error message? |
I just received the same error. I cannot share the target but here's the "whole" (had to truncate it because of its length, but it's always the same Exception) error message:
|
I don't know if it's related but this scan took reaally really long after the printing of "Session ticket manipulation probe executed" (way over 60 Minutes) until it threw the following error
|
Here I ran it again for the same target. This time TLS Scanner crashed before finishing the scan
|
Thanks for sharing these - they indeed hint at some issues in the new session tickets probes. @XoMEX do you have an idea what could cause this? |
Unfortunately, the SessionTicketPaddingOracleProbe is very slow if it thinks it has found something and may store quite some information in memory (java seems to hit some memory limit in the last two traces). I'd recommend
|
The scanDetail was set to NORMAL in both cases. |
Not from the commandline :/ |
Btw, disabling the probe (regarding the OutOfMemoryError and JsonMappingException) is just fighting the symptoms. To solve the OutOfMemoryError some profiling which shows which objects take up that much space would be needed. Regarding the JsonMappingException: This looks like a bug in the serialization of a ResponseFingerprint (more precisely the RenegotiationInfoExtensionMessage within a ServerHello) @ic0ns
|
I am not entirely convinced this is the RenegotiationInfoExtensionMessage, but it is just the first one on the list. Fixing this from just the exception seems tough. Do you have an example to reproduce the issue? |
@m10x can you chat whether a report file is created? If I have seen it correctly we serialize the report twice (which is an issue on its own, but should not affect you)
|
Can you comment out these lines in Scanner.java and try again? |
An empty report file is created |
I'm not able to find a file called Scanner.java or any code line containing "ScanReportSerializer".
in serverscanner and
in clientscanner |
ah I see - it is in the dependency ScannerCore (https://github.com/tls-attacker/Scanner-Core) - you would need to comment it out there and then recompile the server scanner with the modified version of Scanner-Core. |
The RAM problem might be because the VM which I've used had only 2GB RAM left for TLS-Scanner.
I can share the target with you in a DM |
jeah feel free to send me an email [email protected] |
I am getting an error that says :
ERROR: ScanReportSerializer - Could not serialize scan report
com.fasterxml.jackson.databind.JsonMappingException: Document nesting depth (1001) exceeds the maximum allowed .....
I wonder if I'm the only one experiencing this error.
The text was updated successfully, but these errors were encountered: