Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onboarding: revive ready login #4340

Merged
merged 38 commits into from
Jan 20, 2025
Merged

onboarding: revive ready login #4340

merged 38 commits into from
Jan 20, 2025

Conversation

latter-bolden
Copy link
Member

@latter-bolden latter-bolden commented Jan 15, 2025 •
edited
Loading

Handles situations we saw crop up during revival, notably logging into:

  • Unverified accounts
  • Accounts that have no assigned ship
  • Accounts where the ship is paused or suspended
  • Accounts where the ship is under maintenance and cannot be used

Adds functionality for using that same resume stopped ship logic for logged in users as well. If we detect your ship has been paused or suspended it'll kick you to a waiting screen.

Also,

  • complete KV refactor for hosting config
  • move hosting functionality to the api + store pattern we use elsewhere
  • ensure all non-200 hosting responses get logged to PostHog with status + path
  • add analytics for key breakdowns in the flow that we can uses to power a dashboard/alarm

Fixes TLON-3434
Fixes TLON-3433

@latter-bolden
basic wait screen redirect for logging into paused/suspended node
76133c1
@latter-bolden
move analytics events to domain logic
7e8c0f8
@latter-bolden
Merge branch 'develop' into lb/robust-login
4f2c14b
@latter-bolden
more spots
63492d2
@latter-bolden
move hosting key values over to new system
a85ea95
@latter-bolden
move hosting api to shared, types to domain
df6c9ed
@latter-bolden
Merge branch 'develop' into lb/robust-login
955e07d
@latter-bolden
fix import
b24d857
@latter-bolden
stash
f600967
@latter-bolden
finish refactoring, use extracted methods across OTP, Legacy, and Get…
db1cca8 
…tingNodeReady screens
@latter-bolden
remove dead code
36b0a20
@latter-bolden
Merge branch 'develop' into lb/robust-login
c324012
@latter-bolden
cleanup
90ff0b1
@latter-bolden
move more logic over to hostingActions, better analytic sevent capture
f91cfe3
@latter-bolden
handle maintenance conditions
3176a04
@latter-bolden
fix up RequestPhoneVerify & CheckVerify
55441f0
@latter-bolden
fix detecting needs phone verification from hosting user
ec50759
@latter-bolden
new initial onboarding CheckState screen + check for stopped node whi…
8f2e9de 
…le logged in
@latter-bolden
polish visuals for GettingNodeReady screen
d9f9cc4
@latter-bolden
remove dev logs
25e8e9e
@latter-bolden
cleanup comments & dead code
0bf946d
@latter-bolden latter-bolden requested a review from arthyn January 15, 2025 16:46
@linear Linear
Copy link

linear bot commented Jan 15, 2025

TLON-3434 mobile login: edge case handling & telemetry

TLON-3433 mobile onboarding: handle failed "are you human" check

@latter-bolden latter-bolden changed the title onboarding: robust login onboarding: revive ready login Jan 15, 2025
@latter-bolden latter-bolden marked this pull request as ready for review January 15, 2025 22:06
arthyn
arthyn approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@arthyn arthyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nothing blocking just some nits and questions

apps/tlon-mobile/src/App.main.tsx Show resolved Hide resolved
apps/tlon-mobile/src/hooks/useOnboardingHelpers.ts Show resolved Hide resolved
apps/tlon-mobile/src/lib/loginContext.tsx Outdated Show resolved Hide resolved
packages/app/constants.ts Outdated Show resolved Hide resolved
packages/app/hooks/useHandleLogout.native.ts Show resolved Hide resolved
packages/shared/src/store/hostingActions.ts Show resolved Hide resolved
packages/app/lib/bootHelpers.ts Outdated Show resolved Hide resolved
apps/tlon-mobile/src/screens/Onboarding/CheckVerifyScreen.tsx Outdated Show resolved Hide resolved
apps/tlon-mobile/src/screens/Onboarding/SignupScreen.tsx Outdated Show resolved Hide resolved
@latter-bolden latter-bolden merged commit 79734c0 into develop Jan 20, 2025
1 check passed
@latter-bolden latter-bolden deleted the lb/robust-login branch January 20, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthyn arthyn arthyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@latter-bolden @arthyn