Add url, progress and duration for iOS parity #36
Conversation
|
I will test using my project that all works with this commit hash then let you merge. |
| PrintWriter pw = new PrintWriter(sw); | ||
| t.printStackTrace(pw); | ||
| Intent BroadcastIntent = new Intent(Mode.ERROR); | ||
| BroadcastIntent.putExtra("stacktrace", sw.toString()); |
There was a problem hiding this comment.
BroadcastIntent is not used here and I don't think we should pass this much data over the bridge. We should create custom error code maybe, but this is an other issue. Could you remove the stacktrace part ?
There was a problem hiding this comment.
Forgot to remove dead code.
Nowadays, when there is an error that is hard to see why (some of my file were private on AWS and I took me some time). But I agree, it is another feature.
I'm gonna update this PR.
|
It is working perfectly in my project. I did not use getStatus thought, so if you can test that. Thank for the help. |
|
This will be a big help for getting Android closer to feature parity with iOS (ability to track progress). Looks like the 1 remaining thing is the ability to play the audio at a specific starting point. If we could do that with aacdecoder then we would be able to add the seekToTime, goForward, and goBack methods like we have for iOS. I use these methods to give the player a button to advance 30 seconds, rewind 30 seconds like below:
|
|
Any ETA before merge of this PR ? I've sadly worked on the master branch of the fork and I think I will need it the to push some unrelated commits on the fork to be able to debug an issue with some stream on android. If you need more time to review, I can rewrite the history to move this PR's commits into another branch and reopen a new PR with those commits. |
|
@tychota you can just use an other branch based on master for your work if you want. I will not merge this before thursday sadly. |
|
Oki ! I will do that ;) Thank for that pragamatic advice : I had not thought this solution :) |
|
Hello there, I'm sorry but it does not seem to work. What stream did you use to test ? Maybe something is wrong on my side. |
|
Mmh. The progress stuff look weird on my side too. I'm getting progress in percent (progress/duration) between 0 and 100% but they seems to oscillate. I guess it does not take the full file duration as duration but rather the already streamed duration. One coworker also did also catch this today. Since we are playing 1 minute file but over great network, I guess I didn't catch this earlier. Now I'm lost. I don't know what are exactly the information I'm getting but I guess it is only what's buffered. It is clearly not the same as in iOS. And i don't know how to obtain feature parity. Is it ever possible with aacPlayer ? |
|
It appears not, I'm trying to migrate to ExoPlayer anyway that will be much much better to handle this. I'll keep you in touch. |
|
Shall I remove the progress part, open another PR with only url and try to get something smaller merged ? Or do you think this will be lost of time ? |
|
Don't waste your time on this. The url is something that comes from user side anyway so this is not really a problem. I will add it later after the migration. |
|
So let' close :) Sorry that it did not end up being merged :/ |
Fix #35