Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[botcom] emojis: reloaded🕴️ #5124

Open
wants to merge 7 commits into
base: mime/textfields-5
Choose a base branch
from
Open

[botcom] emojis: reloaded🕴️ #5124

wants to merge 7 commits into from

Conversation

mimecuvalo
Copy link
Member

This redoes #2825 (which was #2814 originally) using the new integrated TipTap editor.

everyone ❤️'s emojis: https://dropbox.tech/application/dropbox-paper-emojis-and-exformation

emojis-reloaded.mp4

@mimecuvalo mimecuvalo requested a review from SomeHats December 16, 2024 08:19
@vercel Vercel
Copy link

vercel bot commented Dec 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
examples ✅ Ready (Inspect) Visit Preview Dec 19, 2024 2:41pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
tldraw-docs ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 2:41pm

@steveruizok steveruizok changed the title emojis: reloaded🕴️ [botcom] emojis: reloaded🕴️ Dec 16, 2024
@steveruizok
Copy link
Collaborator

Nice!

Does this come in lazily? That big 500kb json file is scary if it's going to be part of the main JS bundle

@mimecuvalo mimecuvalo mentioned this pull request Dec 16, 2024
Closed
1 task
@mimecuvalo
Copy link
Member Author

Does this come in lazily? That big 500kb json file is scary if it's going to be part of the main JS bundle

yup! it's lazy const EmojiDialog = lazy(() => import('./EmojiDialog'))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SomeHats SomeHats Awaiting requested review from SomeHats

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mimecuvalo @steveruizok