pg_restore, pg_dump: add pages

[mz026]

No description provided.

[igorshubovych]

why do write it like this?

# pg\_restore

it has to be

# pg_restore

[igorshubovych]

`pg_restore -h {{localhost}} -p {{5432}} -U {{username}} -d {{db_name}} {{archive_file.dump}}`

This is complicated example, and you introduce 5 options in it. It is against tldr guidelines. Please split it.

Take a look at mysql page or

[mz026]

just updated, thanks for reviewing!!

2016-01-07 21:15 GMT+08:00 Igor Shubovych [email protected]:

pg_restore -h {{localhost}} -p {{5432}} -U {{username}} -d {{db_name}} {{archive_file.dump}}

This is complicated example, and you introduce 5 options in it. It is
against tldr guidelines. Please split it.

Take a look at mysql page
https://github.com/tldr-pages/tldr/blob/master/pages/common/mysql.md or

—
Reply to this email directly or view it on GitHub
#630 (comment).

[igorshubovych]

I like it much more! Thanks. LGTM.

[igorshubovych]

@mz026 Could you plz squash the commits?

[mz026]

squashed, thanks! @igorshubovych

[waldyrious]

existed --> existing

[notpeter]

You wanna do one for pg_dump too?

[mz026]

sure! I added a pg_dump page. @notpeter
Should I separate them into 2 PRs?

[notpeter]

I'm not the repo owner but I'm sure one PR for paired commands like pg_dump & pg_restore is fine.

On Jan 7, 2016, at 10:16 PM, Yang-Hsing Lin [email protected] wrote:

sure! I added a pg_dump page. @notpeter
Should I separate them into 2 PRs?

—
Reply to this email directly or view it on GitHub.

[mz026]

haha! I'll separate them then.

[waldyrious]

@mz026 I get the feeling you misunderstood @notpeter. Indeed a single PR for related commands is quite acceptable especially since it's desirable to keep any suggested changes in sync. See for instance #605.

[mz026]

thanks for clarifying @waldyrious . I added a pg_dump page on it 😄 @notpeter

[igorshubovych]

It is almost good.
Could you please tune markup a little bit according to our recent changes in guidelines. Capital letters in the beginning and colons in the end of examples' descriptions.

[mz026]

Just updated, thanks! @igorshubovych

[igorshubovych]

Thank you for contribution! 👍