-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
circo, fdp, neato, osage, patchwork, sfdp, twopi: add page #6284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
These changes are in preparation for adding commands: `neato`, `circo`, `twopi`, `pfd`, `spfd`, `osage` and `patchwork`, which use the same command syntax. This one is to argue over before posting the other seven that are generated from the same template. Changes: - use `gv` extension, not `dot`. Author uses `gv`. - link to command usage guide page - specify the type of layout in the description (varies) - use `input` and `image` not `file` or `out_file` - provide a list of available image formats - show how to use the engine as a filter - give the help command
See #6270, #2580. This pull-request contains the other seven graphviz layout commands in addition to `dot`, which is awaiting approval at #6270. These files are generated from the same template as `dot.md` there. The eight commands differ in the command name, description line and the content of the `echo` command in one example. (If any more changes are required, I will regenerate all the files together.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the -T ...
→ -T {{...}}
changes I requested in the dot
PR, everything looks good.
(For fellow maintainers: All the pages are the same, except for the command, so there isn't much to review)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me! Thanks, @daniel-birket :D
Not sure if we should be encouraging people to use the GIF image format though, since it's old, obsolete, and has many limitations such as 256 colours (PNG replaces it in pretty much every way - including animation, though for animation you may wish to consider an actual video file, as it's likely to have an exponentially smaller filesize).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @daniel-birket
See #6270, #2580.
This pull-request contains the other seven graphviz layout commands in
addition to
dot
, which is awaiting approval at #6270. These filesare generated from the same template as
dot.md
there. The eightcommands differ in the command name, description line and the content
of the
echo
command in one example. (If any more changes arerequired, I will regenerate all the files together.)
common/
,linux/
, etc.)