style-guide: put token guidelines into sections & add varargs

[xeruf]

Fixes: #5791

[xeruf]

It was quite unwieldy, now it feels much more manageable to me :)

[marchersimon]

Just a few small suggestions, but looks good overall

[marchersimon]

@xeruf are you still working on this?

[xeruf]

jup, but I haven't been able to keep up with github notifications recently ^^

[marchersimon]

Just two more things I'd like to add

[github-actions]

Hi all! This thread has not had any recent activity.
Are there any updates? Thanks!

[github-actions]

Hi all! This thread has not had any recent activity.
Are there any updates? Thanks!

[blueskyson]

LGTM. but I personally wonder that Is there any reason to replace list marks from number to -?

[marchersimon]

I actually think this would be a benefit, since now we can refer to a specific rule by it's number.

[xeruf]

They had no particular order, and it would be annoying to adjust the numbers when a rule is inserted - also the referencing would misalign after a change.

Two ideas to solve this:

• Numbering per section
• Add a shorthand that identifies each rule, e.g. SHO, CAS, VAL for the three naming rules
  Latter is my favorite as it is more future-proof.

[marchersimon]

I don't think this would be necessary. We don't have to refer to the style-guide that often and we can still refer to the line number or the section

[marchersimon]

Looks good, thanks @xeruf

[CleanMachine1]

lgtm, this PR is way overdue