Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-release: add page #6095

Merged
merged 5 commits into from
Jun 6, 2021
Merged

git-release: add page #6095

merged 5 commits into from
Jun 6, 2021

Conversation

CleanMachine1
Copy link
Member

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

For #5137

This PR and command is cursed, it has coursed me nothing but trouble, I accidentally made a tag on tldr rather than my test repo.
I had to rebase for the first time because of a commit between a good one and another good one

@CleanMachine1 CleanMachine1 added the new command Issues requesting creation of a new page. label Jun 5, 2021
@CleanMachine1 CleanMachine1 mentioned this pull request Jun 5, 2021
73 tasks
Copy link
Collaborator

@marchersimon marchersimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

Copy link
Member

@SethFalco SethFalco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the page looks great, just had one subjective suggestion.

Also, just a question, the page refers to "Git releases", but is a "Release" a native Git feature? I thought Git just has tagging, and that's utilized by GitHub/GitLab/etc for releases?

Edit:

Releases are a feature of GitHub, and are not a feature of general git
- https://stackoverflow.com/a/38675903/6277798

It could be worth just saying "Create a release" instead of "Create a Git release" to keep it agnostic (GitHub/GitLab) but not suggest it's a Git feature.

pages/common/git-release.md Outdated Show resolved Hide resolved
@CleanMachine1 CleanMachine1 merged commit b6b2d9a into main Jun 6, 2021
@CleanMachine1 CleanMachine1 deleted the git-release branch June 6, 2021 19:07
@SethFalco
Copy link
Member

You sure it was fine to merge this already? I gave an additional comment in #6095 (review)
Do you have an opinion on that?

@CleanMachine1
Copy link
Member Author

...
Mistakes have been made. However it is making a type of tag release thing.

It isn't that big of a deal regardless

@SethFalco
Copy link
Member

SethFalco commented Jun 6, 2021

I'll leave that for others to decide. To me, it's a big deal as someone who learns a lot from inference.
If I wasn't familiar with Git, I would've wrongfully learned that "Releases" are a Git feature.

While I am on an extreme when it comes to taking things literally, it's also a more accessible as this is common in people with Autism for example.

taking things very literally – for example, you may not understand sarcasm or phrases like "break a leg"
- https://www.nhs.uk/conditions/autism/signs/adults/

I think it'd be better if the literal meaning was accurate, but that's just my take.

@CleanMachine1 CleanMachine1 restored the git-release branch June 6, 2021 20:02
@CleanMachine1
Copy link
Member Author

Well if you would like me to revert the PR, I am perfectly willing to 👍

@bl-ue bl-ue deleted the git-release branch June 6, 2021 20:04
@CleanMachine1
Copy link
Member Author

I'll make an entire PR instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants