-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINTAINERS: add @SethFalco to collaborators #5994
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't break the file, 👍
Welcome to the maintainer team! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome with ❤️! 🎆
Go ahead and merge this PR yourself when @marchersimon approves, @SethFalco. We always squash, except when someone adds an explicit note to rebase. |
Remember to delete your fork, or at least start using the actual repo to add branches, since you have write access. |
It's actually not necessary to at all — I use my own fork still, just because I like to ;) |
Yes, I shouldn't have worded it like it was mandatory, sorry about that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing |
Have you accepted the invite @SethFalco it doesn't appear above your name. If you have then you need to make your membership public |
Yes of course. I am an idiot. I realised my mistake 20 seconds ago.... got confused with Waples |
Wow @marchersimon that's green for you? Just how did you do it? I've never been able to. |
Green as standard for me. Don't you use some advanced version of Github? |
Oh wait, it's a joke — you're faking an approval @marchersimon? |
Yes |
It's not the most official approval, but it's still as valid 😄 |
Closes #5993