Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINTAINERS: add @SethFalco to collaborators #5994

Merged
merged 1 commit into from
May 19, 2021

Conversation

SethFalco
Copy link
Member

@SethFalco SethFalco commented May 19, 2021

Closes #5993

@navarroaxel navarroaxel changed the title MAINTAINERS: add @SethFalco MAINTAINERS: add @SethFalco to collaborators May 19, 2021
@navarroaxel navarroaxel added the community Issues/PRs dealing with role changes and community organization. label May 19, 2021
Copy link
Member

@CleanMachine1 CleanMachine1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't break the file, 👍

@CleanMachine1
Copy link
Member

Welcome to the maintainer team!

Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome with ❤️! 🎆

@bl-ue
Copy link
Contributor

bl-ue commented May 19, 2021

Go ahead and merge this PR yourself when @marchersimon approves, @SethFalco. We always squash, except when someone adds an explicit note to rebase.

@CleanMachine1
Copy link
Member

Remember to delete your fork, or at least start using the actual repo to add branches, since you have write access.

@bl-ue
Copy link
Contributor

bl-ue commented May 19, 2021

It's actually not necessary to at all — I use my own fork still, just because I like to ;)

@CleanMachine1
Copy link
Member

Yes, I shouldn't have worded it like it was mandatory, sorry about that

@navarroaxel navarroaxel merged commit 8eaccfa into tldr-pages:main May 19, 2021
Copy link
Collaborator

@marchersimon marchersimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

It's never too late to approve 😄

@CleanMachine1
Copy link
Member

Amazing

@CleanMachine1
Copy link
Member

Have you accepted the invite @SethFalco it doesn't appear above your name. If you have then you need to make your membership public

@marchersimon
Copy link
Collaborator

I can see the collaborator badge. 🤔
image

@CleanMachine1
Copy link
Member

Yes of course. I am an idiot. I realised my mistake 20 seconds ago.... got confused with Waples

@bl-ue
Copy link
Contributor

bl-ue commented May 19, 2021

Wow @marchersimon that's green for you? Just how did you do it? I've never been able to.

@CleanMachine1
Copy link
Member

Green as standard for me. Don't you use some advanced version of Github?
Try setting your color scheme to "Default Dark"

@bl-ue
Copy link
Contributor

bl-ue commented May 19, 2021

This is what it looks like for me

Screen Shot 2021-05-19 at 4 15 14 PM

But maybe I'm misunderstanding...?

@bl-ue
Copy link
Contributor

bl-ue commented May 19, 2021

Oh wait, it's a joke — you're faking an approval @marchersimon?

@CleanMachine1
Copy link
Member

Yes
its a picture

@marchersimon
Copy link
Collaborator

Oh wait, it's a joke — you're faking an approval @marchersimon?

It's not the most official approval, but it's still as valid 😄

@SethFalco SethFalco deleted the add-collaborator branch May 29, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues/PRs dealing with role changes and community organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add collaborator: @SethFalco
5 participants