Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upower: add page #5923

Merged
merged 11 commits into from
May 11, 2021
Merged

upower: add page #5923

merged 11 commits into from
May 11, 2021

Conversation

CleanMachine1
Copy link
Member

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@CLAassistant
Copy link

CLAassistant commented May 10, 2021

CLA assistant check
All committers have signed the CLA.

@CleanMachine1
Copy link
Member Author

Sorry, but the cla needs my private email. Who will be able to see that and where will it be listed (eg a contributors file somewhere)

pages/linux/upower.md Outdated Show resolved Hide resolved
@CleanMachine1
Copy link
Member Author

I am perfectly happy to sign the license agreement however I am not willing to give my private email to it

pages/linux/upower.md Outdated Show resolved Hide resolved
pages/linux/upower.md Outdated Show resolved Hide resolved
@bl-ue
Copy link
Contributor

bl-ue commented May 10, 2021

Sorry, but the cla needs my private email. Who will be able to see that and where will it be listed (eg a contributors file somewhere)

@CleanMachine1 None of us have access to your email. I'm not sure what cla-assistant.io does with it, but they certainly keep it private (I don't think any human has access to it on any side).

@CleanMachine1
Copy link
Member Author

Is it mandatory for it to be done?

@bl-ue
Copy link
Contributor

bl-ue commented May 10, 2021

Yes, it is, for legal reasons 😞

There's absoluately no danger of your email being exposed though!

@marchersimon
Copy link
Collaborator

@CleanMachine1 you could however use another email for your commits and add it to your GitHub account.

@CleanMachine1
Copy link
Member Author

Unfortunately not...
The cla agent requests private emails

Also I already use the githubnoreply for commits

I am currently migrating my account so I will have agreed to it in a day or 2

@CleanMachine1
Copy link
Member Author

Don't close this PR and I will have it signed or whatever in the next 24 hours (probably)

nicokosi
nicokosi previously approved these changes May 10, 2021
Copy link
Collaborator

@nicokosi nicokosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me!

@nicokosi nicokosi dismissed their stale review May 10, 2021 15:50

Oops, licence Agreement is missing.

@CleanMachine1
Copy link
Member Author

Read up and see! Good to here its alright though

@CleanMachine1
Copy link
Member Author

Had a free hour, all is done and signed @nicokosi
If you want to give the "review" and merge I would be happy!

@CleanMachine1
Copy link
Member Author

Do you know if I can remove CLA assistant from my account after this is merged?

@bl-ue
Copy link
Contributor

bl-ue commented May 10, 2021

Do you mean unsign the CLA?

@CleanMachine1
Copy link
Member Author

No, remove it from my OAuth applications list, revoking access from my private email

@bl-ue
Copy link
Contributor

bl-ue commented May 10, 2021

Ah yes, I'm sure you can do that. But you'll need to do it all over again if you want to open another PR... 😄

@CleanMachine1
Copy link
Member Author

Ok, well considering it took me 20 seconds to think of topic to cover, I will find another command I use which isn't here.

Overall been enjoying this repo, been using it for around a week.
I have a suggestion I will add, it is for gpg

I often encrypt single files and the command is gpg -c file

Copy link
Collaborator

@marchersimon marchersimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole command isn't just about the battery, but about power in general (including line power, the display, etc.), so I would replace battery with power everywhere.

pages/linux/upower.md Outdated Show resolved Hide resolved
pages/linux/upower.md Outdated Show resolved Hide resolved
pages/linux/upower.md Outdated Show resolved Hide resolved
@CleanMachine1
Copy link
Member Author

Can collab leave reviews, like what you have done. I like the sound of playing a role in helping!

@marchersimon
Copy link
Collaborator

They do. You can also make reviews now, it just doesn't affect the merge status if you approve or request changes.

@CleanMachine1
Copy link
Member Author

Which status do you have to be to make status changes with reviews.

@bl-ue
Copy link
Contributor

bl-ue commented May 10, 2021

Collaborator or organization member. All you need is write access to the repo, which both roles have.

Btw, I'm preparing a reply for you, so be patient ;P

@CleanMachine1
Copy link
Member Author

Ok, I don't know what you are replying to however I look forward to whatever it may be.

@bl-ue
Copy link
Contributor

bl-ue commented May 10, 2021

@CleanMachine1

I see a lot of people lost collaborator status today

That's not true, exactly. @marchersimon opened issues to discuss whether or not we should remove them, but they're

They were interested in the repo at various times over the years, so they were invited as collaborators, to make it easier for them to contribute. As with everyone though, their interests shifted onto other things, so they became less and less active. It's been a while, so they aren't helping out with the maintenance tasks nor contributing pages, so @marchersimon wants to remove them, not as a demotion or punishment or anything of the sort, but as a reflection of their actual involvement in the project :)

how hard is it to gain

Not hard at all! Usually, when we see someone contributor several pages (5 is the minimum per COMMUNITY-ROLES.md), and that person seems particularly active, we open an issue inviting them.

I am very interested in this repo, ever since starting Linux, I always found it an annoyance to scroll through man pages.

❤️

I may start to commit and help more, if you would like me to.

That would be fantastic! Contribution of any kind from any contributor is desired, as this is a community volunteer-based project (i.e. the maintainers were and are just tldr users).

Can collab leave reviews, like what you have done. I like the sound of playing a role in helping!

Any user with a GitHub account can leave reviews on any PR in any public repository. They can comment, suggest code changes, etc. Really, you don't even need to be a collaborator to help out with tldr-pages. But collaborators and organization members/owners (both roles have write access to the repo) can label and close issues/PRs, and merge PRs, in addition to the common things that every user can do.

I like the sound of playing a role in helping!

😍 That would be amazing! Please, open a few more PRs with some nice, high-quality pages (and maybe help out fix a few existing open PRs) and you'll be elligible in no time.

@CleanMachine1
Copy link
Member Author

CleanMachine1 commented May 10, 2021

Well the reason I am so interested is I (for some reason) like to make documentation.
I always hate products that have terrible documentation, software is no exception.
I will probably produce some really small branches, I am currently just about to push a branch which changes a certain word.

I don't expect to gain collab or anything similar from these commits however it would be nice 😄

Expect me to keep following this, even if I stop for a week, continue to ping me with review requests as I will happily do them ASAP.

@marchersimon
Copy link
Collaborator

Some things to check out if you want to:

@bl-ue
Copy link
Contributor

bl-ue commented May 10, 2021

Since you seem to know a bit web development: our i18n page and it's open issues

I didn't think of that! I see you guys have opened some issues there, and I'll watch that repo, too.

pages/linux/upower.md Outdated Show resolved Hide resolved
Co-authored-by: Axel Navarro <[email protected]>
@Waples Waples added the new command Issues requesting creation of a new page. label May 11, 2021
@CleanMachine1
Copy link
Member Author

Push?

@Waples Waples requested a review from marchersimon May 11, 2021 16:50
@Waples
Copy link
Member

Waples commented May 11, 2021

I'm waiting for @marchersimon 's response to my question about the more information link.

@CleanMachine1
Copy link
Member Author

@Waples review?

@bl-ue bl-ue requested a review from Waples May 11, 2021 18:20
Co-authored-by: marchersimon <[email protected]>
@Waples
Copy link
Member

Waples commented May 11, 2021

No need to be so impatient @CleanMachine1.

@Waples Waples merged commit f3fd6fe into tldr-pages:main May 11, 2021
@CleanMachine1
Copy link
Member Author

Not trying to be impatient, sorry about that. Just sending you a notification that your input is wanted

@CleanMachine1 CleanMachine1 deleted the upower branch May 11, 2021 18:32
@navarroaxel
Copy link
Member

Hey @CleanMachine1 join us in our https://gitter.im/tldr-pages/tldr channel

@CleanMachine1
Copy link
Member Author

say hi! 😄

@CleanMachine1 CleanMachine1 mentioned this pull request May 18, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants