Skip to content

Conversation

navarroaxel
Copy link
Collaborator

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

I had to investigate this command, so I publish the result of my investigation. 😁

@navarroaxel navarroaxel added page edit Changes to an existing page(s). new command Issues requesting creation of a new page or PRs adding a new page for a command. labels Apr 11, 2021
@navarroaxel
Copy link
Collaborator Author

I think I will update the gh-pr-merge page when this issue is resolved: cli/cli#1023

@navarroaxel navarroaxel requested a review from bl-ue April 11, 2021 17:47
@navarroaxel navarroaxel requested a review from sbrl April 13, 2021 18:59
Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this our first sub-subcommand? 😺

@marchersimon
Copy link
Contributor

Technically platformio or ip are full of them.

@bl-ue
Copy link
Contributor

bl-ue commented Apr 13, 2021

Yeah, you're right, I meant "our first documented sub-subcommand"

Copy link
Collaborator

@nicokosi nicokosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@marchersimon marchersimon merged commit fa468e6 into master Apr 15, 2021
@marchersimon marchersimon deleted the pages/gh-pr-merge branch April 15, 2021 17:04
@dmmqz dmmqz mentioned this pull request Oct 6, 2025
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new command Issues requesting creation of a new page or PRs adding a new page for a command. page edit Changes to an existing page(s).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants