Skip to content

git-bugreport: add page #5097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 8, 2021
Merged

git-bugreport: add page #5097

merged 3 commits into from
Jan 8, 2021

Conversation

@bl-ue
Copy link
Contributor

@bl-ue bl-ue commented Jan 6, 2021

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

For #3953

@bl-ue bl-ue added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Jan 6, 2021
@tldr-bot
Copy link

tldr-bot commented Jan 6, 2021

The build for this PR failed with the following error(s):

pages/common/git-bugreport.md:3 MD013/line-length Line length [Expected: 250; Actual: 289]

Please fix the error(s) and push again.

@bl-ue
Copy link
Contributor Author

bl-ue commented Jan 6, 2021 

pages/common/git-bugreport.md:3 MD013/line-length Line length [Expected: 250; Actual: 289]

tldrl doesn't report this... 🤔

@bl-ue bl-ue mentioned this pull request Jan 6, 2021
Open
sbrl
sbrl requested changes Jan 7, 2021
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new page! I've left some comments below for you to review.

@bl-ue @sbrl
Apply suggestions from code review
310baa8 
Co-authored-by: Starbeamrainbowlabs <[email protected]>
@bl-ue bl-ue requested review from sbrl and schneiderl January 7, 2021 03:25
sbrl
sbrl approved these changes Jan 7, 2021
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bl-ue!

@navarroaxel navarroaxel merged commit 4ebca80 into master Jan 8, 2021
@navarroaxel navarroaxel deleted the git/bugreport branch January 8, 2021 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@navarroaxel navarroaxel navarroaxel approved these changes

@sbrl sbrl sbrl approved these changes

@schneiderl schneiderl Awaiting requested review from schneiderl

Assignees

No one assigned

Labels

new command Issues requesting creation of a new page or PRs adding a new page for a command.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bl-ue @tldr-bot @navarroaxel @sbrl