Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asciiart: add page #4962

Merged
merged 3 commits into from
Nov 21, 2020
Merged

asciiart: add page #4962

merged 3 commits into from
Nov 21, 2020

Conversation

sahilister
Copy link
Collaborator

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@navarroaxel
Copy link
Member

Could you merge with the upstream master to pass the CI check? Let me know if you need help to resolve that.

@navarroaxel navarroaxel added the new command Issues requesting creation of a new page. label Nov 18, 2020
ci: fix issue with `set-env` usage (tldr-pages#4964)
@sahilister
Copy link
Collaborator Author

Thanks for asking @navarroaxel .

Updated my fork with upstream, passing the CI checks.

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! It looks like it even has an Ubuntu package. I was looking for a cross-cpu-architecture solution to this problem. Thanks!

pages/linux/asciiart.md Outdated Show resolved Hide resolved
pages/linux/asciiart.md Outdated Show resolved Hide resolved
pages/linux/asciiart.md Outdated Show resolved Hide resolved
pages/linux/asciiart.md Outdated Show resolved Hide resolved
pages/linux/asciiart.md Outdated Show resolved Hide resolved
Co-authored-by: Starbeamrainbowlabs <[email protected]>
@navarroaxel navarroaxel merged commit b77cd3c into tldr-pages:master Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants